Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Val - Edges - MediaRanker Revisited #28

Open
wants to merge 31 commits into
base: master
Choose a base branch
from

Conversation

valgidzi
Copy link

No description provided.

@droberts-sea
Copy link

MediaRanker Revisted

What We're Looking For

Feature Feedback
General
Appropriate Tests on WorksController yes
Appropriate Tests on SessionsController yes
Appropriate Tests on UsersController yes
Completed OAuth yes
Basic Authorization (who can see what) yes
Overall Great work overall!

describe "index" do
it "succeeds when there are works" do
perform_login(user)
get users_path

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since all of these tests require the user to be logged in, the perform_login might go well in a before block.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants