Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Danielle - MediaRanker-Revisited #24

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Danielle - MediaRanker-Revisited #24

wants to merge 7 commits into from
+551 −64

Conversation

danimetz
Copy link

No description provided.

@CheezItMan
Copy link

MediaRanker Revisted

What We're Looking For

Feature Feedback
General
Appropriate Tests on WorksController Check, nicely done
Appropriate Tests on SessionsController Check
Appropriate Tests on UsersController Check
Completed OAuth Check
Overall Well done, you hit all the learning goals. Great work!

CheezItMan
CheezItMan reviewed Oct 31, 2018
View reviewed changes
test/controllers/sessions_controller_test.rb
expect {
perform_login(user)
}.wont_change 'User.count'

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could also test a flash notice here.

test/controllers/sessions_controller_test.rb

it "creates a new user and redirects to root path" do
user = users(:ada)
user.destroy
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to destroy the user's vote first, before destroying the user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CheezItMan CheezItMan CheezItMan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danimetz @CheezItMan