Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Windows to CI #267

Closed
wants to merge 3 commits into from
Closed

Introduce Windows to CI #267

wants to merge 3 commits into from

Conversation

paulo-ferraz-oliveira
Copy link
Contributor

Note that this pull request introduces Windows to the CI BUT does not fix the issues derived from it. It can either be used as an example or the issues can be fixed in the main branch, after which this can be rebased.

@CLAassistant
Copy link

CLAassistant commented Jun 8, 2021

CLA assistant check
All committers have signed the CLA.

@elbrujohalcon
Copy link
Collaborator

Woah! I wasn't expecting warning: LF will be replaced by CRLF in… errors 😓
@ElectronicRU do you think you will be able to fix them?

@ElectronicRU
Copy link
Collaborator

ElectronicRU commented Jun 8, 2021

Woah! I wasn't expecting warning: LF will be replaced by CRLF in… errors 😓
@ElectronicRU do you think you will be able to fix them?

Yeah - git -c core.autocrlf input should do the trick.
(But also perhaps we should actually use git status --porcelain like God intended, and only capture stdout from git-diff to show an error)

@paulo-ferraz-oliveira
Copy link
Contributor Author

If there's something you want me to do in the scope of this pull request let me know.

@ElectronicRU
Copy link
Collaborator

@paulo-ferraz-oliveira oh, no, grand work dude, didn't expect you'd find time to do it so quickly! Sorry for pinging your notifs!

@paulo-ferraz-oliveira
Copy link
Contributor Author

paulo-ferraz-oliveira commented Jun 9, 2021

Rebased over main and force-pushed to stimulate CI again.

Edit: nope, still broken.

@elbrujohalcon elbrujohalcon requested a review from pbrudnick June 10, 2021 06:44
@elbrujohalcon
Copy link
Collaborator

@paulo-ferraz-oliveira please check paulo-ferraz-oliveira/rebar3_format#1 🙏🏻

@paulo-ferraz-oliveira
Copy link
Contributor Author

@paulo-ferraz-oliveira please check paulo-ferraz-oliveira#1 🙏🏻

Let me check this on Monday. OTOH, I was under the impression you could change my pull request directly, as per "If checked, users with write access to AdRoll/rebar3_format can add new commits to your feature/windows_ci branch. You can always change this setting later." (option to the right)

@paulo-ferraz-oliveira
Copy link
Contributor Author

I'm updating this so it uses the newly released erlef/setup-beam@v1, and maybe serves as a source for the other pending pull request, #268.

@paulo-ferraz-oliveira
Copy link
Contributor Author

I'm closing this PR as it's not actually solving anything, it was just showing how to introduce Windows to CI.

@paulo-ferraz-oliveira paulo-ferraz-oliveira deleted the feature/windows_ci branch July 13, 2021 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants