Update Deployment Dockerfile. Minor fixes. #99
Conversation
|
Manuel Garrido seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
|
manugarri
changed the title
|
side note, i signed the cla, not sure why is not showing up. |
|
@JonathanAquino-NextRoll FYI we are going to try ODD (another platform) since its clear this project is not maintained anymore (at least not for users other than Adroll itself). |
|
ok, sorry about this - super busy |
There was a problem hiding this comment.
@manugarri Not sure if you are still interested, but I have time this week to review and merge your PR.
| @@ -1,6 +1,7 @@ | |||
| FROM node:10.15.3-stretch | |||
|
|
|||
| # AWS cli tools | |||
| RUN echo "deb http://archive.debian.org/debian stretch main" > /etc/apt/sources.list | |||
There was a problem hiding this comment.
If you pull from master, we don't need this line anymore. I upgraded from stretch to buster.
| @@ -156,6 +156,8 @@ func syncJobsStatus(storer jobs.Storer, status string, queues []string, job_summ | |||
| var run_started_time *time.Time | |||
| var log_stream_name *string | |||
| var task_arn *string | |||
| var log_group_name *string | |||
| log_group_name = desc.Container.LogConfiguration.Options["awslogs-group"] | |||
There was a problem hiding this comment.
I'm getting the panic below when I run docker-compose up - maybe because I haven't configured awslogs-group?
api_1 | 18:43:54 app | panic: runtime error: invalid memory address or nil pointer dereference
api_1 | [signal SIGSEGV: segmentation violation code=0x1 addr=0x8 pc=0x64b5c0]
api_1 |
api_1 | goroutine 24 [running]:
api_1 | 18:43:54 app | github.com/AdRoll/batchiepatchie/syncer.syncJobsStatus({0xffff89b28098, 0x40000acd68}, {0x94eb22, 0x6}, {0x40000200d0, 0x1, 0x40?}, 0x2?, {0xc68d00, 0x12571a0})
api_1 | /go/src/github.com/AdRoll/batchiepatchie/syncer/batchsync.go:161 +0x1000
api_1 | github.com/AdRoll/batchiepatchie/syncer.syncJobs({0xffff89b28098, 0x40000acd68}, {0x40000200d0, 0x1, 0x1})
api_1 | /go/src/github.com/AdRoll/batchiepatchie/syncer/batchsync.go:272 +0x1f8
api_1 | github.com/AdRoll/batchiepatchie/syncer.RunSynchronizer({0xc6a0d0?, 0x40000acd68
api_1 | 18:43:54 app | }, {0x40000200d0, 0x1, 0x1})
api_1 | /go/src/github.com/AdRoll/batchiepatchie/syncer/batchsync.go:359 +0x5c
api_1 | github.com/AdRoll/batchiepatchie/syncer.RunPeriodicSynchronizer.func1()
api_1 | /go/src/github.com/AdRoll/batchiepatchie/syncer/batchsync.go
api_1 | 18:43:54 app | :344 +0x168
api_1 | created by github.com/AdRoll/batchiepatchie/syncer.RunPeriodicSynchronizer
api_1 | /go/src/github.com/AdRoll/batchiepatchie/syncer/batchsync.go:320 +0xb0
| @@ -906,14 +911,19 @@ func (pq *postgreSQLStore) UpdateTaskArnsInstanceIDs(ec2info map[string]Ec2Info, | |||
| if !ok { | |||
| continue | |||
| } | |||
| public_ip := "" | |||
| if ec2_info.PublicIP != nil { | |||
| log.Info("PUBLIC IP NOT NILL", ec2_info.PublicIP) | |||
There was a problem hiding this comment.
| log.Info("PUBLIC IP NOT NILL", ec2_info.PublicIP) | |
| log.Info("PUBLIC IP NOT NIL", ec2_info.PublicIP) |
As of March 2023, Debian stretch apt repositories have been archived, making the frontend Dockerfile fail.
This PR allows the frontend Dockerfile to continue to be built.
This pr also fixes other more crucial issues if this project is to support other aws setups.