Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add support for application default credentials #92

Merged
merged 11 commits into from
Nov 15, 2024

Conversation

cermakjiri
Copy link
Member

@cermakjiri cermakjiri commented Oct 21, 2024

If none of these environment variables (LOKSE_SERVICE_ACCOUNT_EMAIL & LOKSE_PRIVATE_KEY or LOKSE_API_KEY) have been provided, lokse fallbacks to application default credential authentication.


@cermakjiri cermakjiri requested a review from pavelsvagr October 21, 2024 09:50
@cermakjiri cermakjiri self-assigned this Oct 21, 2024
@pavelsvagr
Copy link
Member

I would discontinue LOKSE_SERVICE_ACCOUNT_EMAIL & LOKSE_PRIVATE_KEY in favor of GOOGLE_APPLICATION_CREDENTIALS which is a standard way to provide a service account to ADC auth.

@cermakjiri cermakjiri force-pushed the feat/application-default-credential branch from afdde5d to 791d7ab Compare November 15, 2024 14:19
@cermakjiri cermakjiri force-pushed the feat/application-default-credential branch from eb36ab4 to 278d9c2 Compare November 15, 2024 15:24
@cermakjiri cermakjiri force-pushed the feat/application-default-credential branch 5 times, most recently from 1feb7da to 025bba8 Compare November 15, 2024 16:12
@cermakjiri cermakjiri force-pushed the feat/application-default-credential branch from 025bba8 to dcbb5ee Compare November 15, 2024 16:15
@cermakjiri
Copy link
Member Author

I would discontinue LOKSE_SERVICE_ACCOUNT_EMAIL & LOKSE_PRIVATE_KEY in favor of GOOGLE_APPLICATION_CREDENTIALS which is a standard way to provide a service account to ADC auth.

Let's make more drastic changes in upcoming major version and now just release it within minor version.

@cermakjiri cermakjiri merged commit f7afb06 into master Nov 15, 2024
1 check passed
@cermakjiri cermakjiri deleted the feat/application-default-credential branch November 15, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants