Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fallback plugin not finding default language column #100

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

2bad2furious
Copy link

Fallback plugin used Object.keys on the row to see all available columns, this may have worked in the past but now only finds internal properties of the row object.

Also updated tests to avoid this issue in the future, but the implementation is still not ideal - I am open to ideas

@2bad2furious 2bad2furious self-assigned this Dec 2, 2024
Copy link
Member

@cermakjiri cermakjiri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cermakjiri cermakjiri merged commit 3dff337 into main Dec 2, 2024
1 check passed
@cermakjiri cermakjiri deleted the fix/find-fallback-column branch December 2, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants