👷‍♂️ Try build in PR workflow (#146)

* 👷‍♂️ Try build in PR workflow * 🔧 Use recommended build settings * 🚨 Solve some compiler warnings
AckeeCZ · Feb 7, 2024 · 8eee630 · 8eee630
1 parent 878fee9
commit 8eee630
Show file tree

Hide file tree

Showing 11 changed files with 42 additions and 97 deletions.
diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml
@@ -3,6 +3,9 @@ name: PR
 on: [pull_request]
 
 jobs:
+  build:
+    name: Test build
+    uses: ./.github/workflows/build.yml
   tests:
     name: Tests
     uses: ./.github/workflows/tests.yml

diff --git a/ACKategories.xcodeproj/project.pbxproj b/ACKategories.xcodeproj/project.pbxproj
diff --git a/ACKategories.xcodeproj/xcshareddata/xcschemes/ACKategories.xcscheme b/ACKategories.xcodeproj/xcshareddata/xcschemes/ACKategories.xcscheme
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <Scheme
-   LastUpgradeVersion = "1500"
+   LastUpgradeVersion = "1520"
    version = "1.7">
    <BuildAction
       parallelizeBuildables = "YES"

diff --git a/ACKategories.xcodeproj/xcshareddata/xcschemes/ACKategoriesTesting.xcscheme b/ACKategories.xcodeproj/xcshareddata/xcschemes/ACKategoriesTesting.xcscheme
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <Scheme
-   LastUpgradeVersion = "1510"
+   LastUpgradeVersion = "1520"
    version = "1.7">
    <BuildAction
       parallelizeBuildables = "YES"

diff --git a/ACKategories.xcodeproj/xcshareddata/xcschemes/Networking.xcscheme b/ACKategories.xcodeproj/xcshareddata/xcschemes/Networking.xcscheme
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <Scheme
-   LastUpgradeVersion = "1510"
+   LastUpgradeVersion = "1520"
    version = "1.7">
    <BuildAction
       parallelizeBuildables = "YES"

diff --git a/ACKategories.xcodeproj/xcshareddata/xcschemes/PushNotifications.xcscheme b/ACKategories.xcodeproj/xcshareddata/xcschemes/PushNotifications.xcscheme
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <Scheme
-   LastUpgradeVersion = "1510"
+   LastUpgradeVersion = "1520"
    version = "1.7">
    <BuildAction
       parallelizeBuildables = "YES"

diff --git a/ACKategories.xcworkspace/xcshareddata/IDEWorkspaceChecks.plist b/ACKategories.xcworkspace/xcshareddata/IDEWorkspaceChecks.plist
diff --git a/Sources/ACKategoriesTesting/Networking/APIServiceMock.swift b/Sources/ACKategoriesTesting/Networking/APIServiceMock.swift
@@ -27,6 +27,8 @@ public final class APIService_Mock: APIServicing {
             case .url(let url): return url
             case .path(let path):
                 return .ackeeCZ.appendingPathComponent(path)
+            @unknown default:
+                fatalError("Unknown case not supposed to be called")
             }
         }()
 

diff --git a/Sources/ACKategoriesTesting/Networking/NetworkMock.swift b/Sources/ACKategoriesTesting/Networking/NetworkMock.swift
@@ -2,7 +2,7 @@ import Foundation
 import Networking
 
 @available(tvOS 13.0, iOS 13.0, watchOS 6.0, macOS 10.15, *)
-public final class Network_Mock: Networking {
+public final class Network_Mock: Network {
     public var requestBody: (URLRequest) async throws -> HTTPResponse = { _ in .test() }
 
     public init() {

diff --git a/Sources/Networking/APIService.swift b/Sources/Networking/APIService.swift
@@ -14,7 +14,7 @@ public final class APIService: APIServicing {
     }
 
     private let baseURLFactory: () -> URL
-    private let network: Networking
+    private let network: Network
     private let requestInterceptors: [RequestInterceptor]
     private let responseInterceptors: [ResponseInterceptor]
 
@@ -26,7 +26,7 @@ public final class APIService: APIServicing {
     ///   - responseInterceptors: List of response interceptors, useful for logging or token refresh
     public init(
         baseURL: @autoclosure @escaping () -> URL,
-        network: Networking,
+        network: Network,
         requestInterceptors: [RequestInterceptor] = [],
         responseInterceptors: [ResponseInterceptor] = []
     ) {

diff --git a/Sources/Networking/Networking.swift b/Sources/Networking/Networking.swift
@@ -2,15 +2,15 @@ import Foundation
 
 /// Protocol wrapping raw network requests, basically URLSession
 @available(tvOS 13.0, iOS 13.0, watchOS 6.0, macOS 10.15, *)
-public protocol Networking {
+public protocol Network {
     /// Send given request
     /// - Parameter request: Request to be sent
     /// - Returns: Received response
     func request(_ request: URLRequest) async throws -> HTTPResponse
 }
 
 @available(tvOS 13.0, iOS 13.0, watchOS 6.0, macOS 12.0, *)
-extension URLSession: Networking {
+extension URLSession: Network {
     public func request(_ request: URLRequest) async throws -> HTTPResponse {
         let (data, response) = try await data(for: request)