Merge pull request #100 from AckeeCZ/fix/flash-news

🐛 Fix navigation controller's delegate on flow coordinator that is navigation root

ACKategories-iOS/Base/FlowCoordinator.swift

@@ -170,7 +170,17 @@ extension Base {
         // MARK: - UINavigationControllerDelegate
 
         public func navigationController(_ navigationController: UINavigationController, didShow viewController: UIViewController, animated: Bool) {
-            if let rootViewController = rootViewController, !navigationController.viewControllers.contains(rootViewController) {
+            // Check if the root is not dead
+            guard let rootViewController = rootViewController else { return }
+
+            // If the navigation controller is the current root view controller
+            // then this method shouldn't get called.
+            // But that's not possible with our current implementation.
+            guard self.navigationController != rootViewController else { return }
+
+            // If `rootViewController` is not present in the navigation stack
+            // we have to stop the current flow
+            if !navigationController.viewControllers.contains(rootViewController) {
                 navigationController.delegate = parentCoordinator
                 stop()
             }

CHANGELOG.md

@@ -10,6 +10,7 @@
 
 ### Fixed
 
+- Check if `navigationController != rootViewController` before running navigation delegate method ([#100](https://github.com/AckeeCZ/ACKategories/pull/100), kudos to @lukashromadnik)
 - `GradientView` has `isUserInteractionEnabled = false` as it is not supposed to be interactive by design ([#99](https://github.com/AckeeCZ/ACKategories/pull/99), kudos to @olejnjak)
 - Check the value of `rootViewController` before stopping the flow ([#98](https://github.com/AckeeCZ/ACKategories/pull/98), kudos to @lukashromadnik)