-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support custom role descriptions #316
Conversation
d3458f5
to
17451d8
Compare
@DataTriny Are you sure that returning Also, I believe we need to separate the documentation into its own PR, to avoid making a semver-breaking release of the base accesskit crate. Yes, it's annoying that we have to work around the release automation again. |
@mwcampbell It depends on which property is more important: the end-user might get more information from the localized role description. "role description" strongly suggests that it can be used in conjunction with platform-specific roles, halas this is not the case with AT-SPI. I chose to do it like this to have a consistent behavior on all platforms, but your arguments are valid as well. Yes, I'll extract the documentation update once we settle on a resolution. |
OK, if the only way to get AT-SPI clients to pay attention to the role description is to use |
I wonder if we can get this one finished before I publish releases. I'm OK with the current implementation for AT-SPI, using the |
Sure! I'll try to do that today or tomorrow. |
be1e9a9
to
1bf74ed
Compare
Revamping an old branch, initial work by @mwcampbell.
Implement support for the
role_description
property on all adapters:GetLocalizedRoleName
method of theorg.a11y.atspi.Accessible
interface. Make use ofAtspiRole::Extended
if a value is supplied, as it is the only way to tell libatspi to query it. Orca still won't announce it because it currently explicitly ignore this role, Accerciser however displays it properly.Tested on all platforms by modifying the winit example.