fix: Support text fields without a value property #274
+108
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erty; Windows only
… where the provider doesn't directly set an outer value
DataTriny
approved these changes
Aug 16, 2023
Merged
lunixbochs
pushed a commit
to talonvoice/accesskit
that referenced
this pull request
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a provider properly implements text field controls, setting the value property on the outer text field node is redundant, because the text is already provided in the inner inline text boxes. I expect that this would be a performance problem for large amounts of text. So now,
accesskit_consumerprovides its own value property for single-line text controls, based on the inner text. For multi-line controls without an outer value property, the macOS adapter fires value change events as appropriate, just as the Windows adapter already fires text change events. I've tested these changes on both Windows and macOS using a modified version of egui that doesn't set the value property on the text field.