Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for synchronous mode in rez-pkg-cache #1834

Closed
wants to merge 72 commits into from
Closed

Add support for synchronous mode in rez-pkg-cache #1834

wants to merge 72 commits into from

Conversation

Pixel-Minions
Copy link
Contributor

Add support for synchronous and asynchronous package caching modes via argparse in pkg-cache.py

@Pixel-Minions Pixel-Minions requested a review from a team as a code owner September 26, 2024 18:57
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Sep 26, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@codecov Codecov
Copy link

codecov bot commented Sep 26, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 58.51%. Comparing base (8476696) to head (29bf0b5).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
src/rez/cli/pkg-cache.py 20.00% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1834      +/-   ##
==========================================
- Coverage   58.52%   58.51%   -0.01%     
==========================================
  Files         126      126              
  Lines       17207    17211       +4     
  Branches     3519     3520       +1     
==========================================
+ Hits        10070    10071       +1     
- Misses       6468     6471       +3     
  Partials      669      669

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Pixel-Minions and others added 26 commits September 26, 2024 17:26
@Pixel-Minions
Remove Python2-related __future__ imports (AcademySoftwareFoundation#…
6380581 
…1640)

Signed-off-by: Pavel Vergeev <[email protected]>
@Pixel-Minions
Remove the note about Python 2.7 compatibility from the docs (Academy…
ab1b958 
…SoftwareFoundation#1644)

Signed-off-by: Pavel Vergeev <[email protected]>
@Pixel-Minions
Add support for virtualenv in installer
a2a7348 
Signed-off-by: Jose Enriquez <[email protected]>
@Pixel-Minions
Run workflows when install script is modified
06eaccf 
Signed-off-by: Jean-Christophe Morin <[email protected]>
@Pixel-Minions @JeanChristopheMorinPerso
Add support for virtualenv in installer (AcademySoftwareFoundation#1645)
bc6d5e4 
* Add support for virtualenv in installer

Signed-off-by: Jose Enriquez <[email protected]>

* Run workflows when install script is modified

Signed-off-by: Jean-Christophe Morin <[email protected]>

---------

Signed-off-by: Jose Enriquez <[email protected]>
Signed-off-by: Jean-Christophe Morin <[email protected]>
Co-authored-by: Jean-Christophe Morin <[email protected]>
@Pixel-Minions
Remove rez.vendor.enum (AcademySoftwareFoundation#1649)
d09c08d 
Signed-off-by: predat <[email protected]>
@Pixel-Minions
Add clear information on how to contact project maintainers (AcademyS…
296583c 
…oftwareFoundation#1659)

Signed-off-by: Jean-Christophe Morin <[email protected]>
@Pixel-Minions
Improve install docs by mentioning how to actually download rez (Acad…
037879c 
…emySoftwareFoundation#1660)

Signed-off-by: Jean-Christophe Morin <[email protected]>
@Pixel-Minions
Remove rez.backport (AcademySoftwareFoundation#1634)
9ce3e02 
Signed-off-by: Bryce Gattis <[email protected]>
@Pixel-Minions
Upload test coverage to Codecov (AcademySoftwareFoundation#1671)
887d506 
Signed-off-by: Jean-Christophe Morin <[email protected]>
@Pixel-Minions
Remove Python 2 support for utils/json.py (AcademySoftwareFoundation#…
61512b8 
…1673)

* Delete rez/utils/json.py

---------

Signed-off-by: Bryce Gattis <[email protected]>
@Pixel-Minions
Add development environment docs (AcademySoftwareFoundation#1633)
85aaa8d 
Signed-off-by: Bryce Gattis <[email protected]>
@Pixel-Minions
Remove rez.utils.py23 and cleanup more python 2.7 leftovers (AcademyS…
4724700 
…oftwareFoundation#1678)

* remove rez.utils.py23 module
* remove some more __nonzero__ methods

---------

Signed-off-by: wwn <[email protected]>
@Pixel-Minions
Improve explicitness of help doc of --command on rez-env
7ed5ce6 
Signed-off-by: brycegbrazen <[email protected]>
@Pixel-Minions
Address notes
0f1ac79 
Signed-off-by: brycegbrazen <[email protected]>
@Pixel-Minions
update sonarcloud python property (AcademySoftwareFoundation#1686)
5411af6 
Signed-off-by: Stephen Mackenzie <[email protected]>
@Pixel-Minions @JeanChristopheMorinPerso
Tick off several completed boxes in onboarding document (AcademySoftw…
fecb35a 
…areFoundation#1691)

* Tick off several completed boxes in onboarding document

Signed-off-by: Stephen Mackenzie <[email protected]>

* Update ASWF/ONBOARDING.md

Signed-off-by: Jean-Christophe Morin <[email protected]>

---------

Signed-off-by: Stephen Mackenzie <[email protected]>
Signed-off-by: Jean-Christophe Morin <[email protected]>
Co-authored-by: Jean-Christophe Morin <[email protected]>
@Pixel-Minions
Add retry mechanism when renaming folders on Windows (AcademySoftware…
df4cf31 
…Foundation#1666)

This will fix issues when rez-cp could fail in some situations on WIndows.

Signed-off-by: loonghao <[email protected]>
@Pixel-Minions
Add -e/--editable flag to install script to create an editable install (
3bc7c5d 
AcademySoftwareFoundation#1672)

Signed-off-by: Jean-Christophe Morin <[email protected]>
@Pixel-Minions @pmolodo
Apply package orderers on variants (AcademySoftwareFoundation#1684)
98c4ea0 
Previously, package orderers were only applied on packages. This was an oversight. With this change, they are now applied to variants too.

---------

Signed-off-by: Ben Andersen <[email protected]>
Co-authored-by: Paul Molodowitch <[email protected]>
@Pixel-Minions
Add releasing packages documentation (AcademySoftwareFoundation#1689)
ccd8241 
Signed-off-by: Bryce Gattis <[email protected]>
@Pixel-Minions
Improve clarify of early binding functions documentation (AcademySoft…
af46f92 
…wareFoundation#1677)

Improve clarify of early binding functions documentation by documenting what is accessible within an early function.

Signed-off-by: Bryce Gattis <[email protected]>
@Pixel-Minions
Bump version to 3.1.0 (AcademySoftwareFoundation#1702)
d3f0dd3 
Signed-off-by: Jean-Christophe Morin <[email protected]>
@Pixel-Minions
Fix typo in "Releasing packages" docs (AcademySoftwareFoundation#1704)
fe5fc96 
Signed-off-by: Jer <[email protected]>
@Pixel-Minions
Remove unnecessary variable assignment in rez.deprecations (AcademySo…
6c5c395 
…ftwareFoundation#1696)

Signed-off-by: Bryce Gattis <[email protected]>
@Pixel-Minions @JeanChristopheMorinPerso
Convert all plugin rezconfig to rezconfig.py (AcademySoftwareFoundati…
007d24f 
…on#1692)

Signed-off-by: brycegbrazen <[email protected]>
Signed-off-by: Jean-Christophe Morin <[email protected]>
Co-authored-by: Jean-Christophe Morin <[email protected]>
Pixel-Minions and others added 20 commits September 26, 2024 17:27
@Pixel-Minions
Pin GH actions to commit hash as recommended by scorecard (AcademySof…
6d985f1 
…twareFoundation#1781)

Signed-off-by: Jean-Christophe Morin <[email protected]>
@Pixel-Minions
Restrict permissions in GHA workflows (AcademySoftwareFoundation#1782)
c2ec1b2 
Signed-off-by: Jean-Christophe Morin <[email protected]>
@Pixel-Minions @dependabot
Bump actions/checkout from 4.1.1 to 4.1.7 (AcademySoftwareFoundation#…
2aa7575 
…1785)

Bumps [actions/checkout](https://github.com/actions/checkout) from 4.1.1 to 4.1.7.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v4.1.1...692973e)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@Pixel-Minions @dependabot
Bump actions/upload-artifact from 4.3.2 to 4.3.3 (AcademySoftwareFoun…
24abaf8 
…dation#1784)

Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.3.2 to 4.3.3.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@v4.3.2...6546280)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@Pixel-Minions @dependabot
Bump github/codeql-action from 3.25.10 to 3.25.11 (AcademySoftwareFou…
c79f86e 
…ndation#1783)

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.25.10 to 3.25.11.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@23acc5c...b611370)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@Pixel-Minions @dependabot
Bump actions/upload-artifact from 4.3.3 to 4.3.4 (AcademySoftwareFoun…
a6576c6 
…dation#1790)

Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.3.3 to 4.3.4.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@6546280...0b2256b)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@Pixel-Minions @dependabot
Bump actions/download-artifact from 4.1.7 to 4.1.8 (AcademySoftwareFo…
1482bfd 
…undation#1789)

Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 4.1.7 to 4.1.8.
- [Release notes](https://github.com/actions/download-artifact/releases)
- [Commits](actions/download-artifact@65a9edc...fa0a91b)

---
updated-dependencies:
- dependency-name: actions/download-artifact
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@Pixel-Minions @dependabot
Bump github/codeql-action from 3.25.11 to 3.25.12 (AcademySoftwareFou…
b2f8347 
…ndation#1795)

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.25.11 to 3.25.12.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@b611370...4fa2a79)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@Pixel-Minions @dependabot
Bump actions/setup-python from 5.1.0 to 5.1.1 (AcademySoftwareFoundat…
d49bde0 
…ion#1794)

Bumps [actions/setup-python](https://github.com/actions/setup-python) from 5.1.0 to 5.1.1.
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](actions/setup-python@82c7e63...39cd149)

---
updated-dependencies:
- dependency-name: actions/setup-python
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@Pixel-Minions @JeanChristopheMorinPerso
Fix TypeError when running get_rpaths on rez.utils.elf module (Academ…
12d0c66 
…ySoftwareFoundation#1798)

Signed-off-by: Ruzette Krukkert <[email protected]>
Signed-off-by: Jean-Christophe Morin <[email protected]>
Co-authored-by: Jean-Christophe Morin <[email protected]>
@Pixel-Minions @dependabot
Bump github/codeql-action from 3.25.12 to 3.26.5 (AcademySoftwareFoun…
4d23f59 
…dation#1816)

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.25.12 to 3.26.5.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@4fa2a79...2c779ab)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@Pixel-Minions @dependabot
Bump actions/upload-artifact from 4.3.4 to 4.3.6 (AcademySoftwareFoun…
98b9051 
…dation#1814)

Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.3.4 to 4.3.6.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@0b2256b...834a144)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@Pixel-Minions @dependabot
Bump ossf/scorecard-action from 2.3.3 to 2.4.0 (AcademySoftwareFounda…
e2289c2 
…tion#1805)

Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action) from 2.3.3 to 2.4.0.
- [Release notes](https://github.com/ossf/scorecard-action/releases)
- [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md)
- [Commits](ossf/scorecard-action@dc50aa9...62b2cac)

---
updated-dependencies:
- dependency-name: ossf/scorecard-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@Pixel-Minions @dependabot
Bump github/codeql-action from 3.26.5 to 3.26.7 (AcademySoftwareFound…
1a0ee1f 
…ation#1827)

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.26.5 to 3.26.7.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@2c779ab...8214744)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@Pixel-Minions @dependabot
Bump actions/setup-python from 5.1.1 to 5.2.0 (AcademySoftwareFoundat…
52c2f79 
…ion#1820)

Bumps [actions/setup-python](https://github.com/actions/setup-python) from 5.1.1 to 5.2.0.
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](actions/setup-python@39cd149...f677139)

---
updated-dependencies:
- dependency-name: actions/setup-python
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@Pixel-Minions @dependabot
Bump actions/upload-artifact from 4.3.6 to 4.4.0 (AcademySoftwareFoun…
907cd19 
…dation#1819)

Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.3.6 to 4.4.0.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@834a144...5076954)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@Pixel-Minions @dependabot
Update sphinx requirement from <8.0.0,>=7.0.0 to >=7.0.0,<9.0.0 in /d…
0d73bfa 
…ocs (AcademySoftwareFoundation#1804)

Updates the requirements on [sphinx](https://github.com/sphinx-doc/sphinx) to permit the latest version.
- [Release notes](https://github.com/sphinx-doc/sphinx/releases)
- [Changelog](https://github.com/sphinx-doc/sphinx/blob/master/CHANGES.rst)
- [Commits](sphinx-doc/sphinx@v7.0.0...v8.0.0)

---
updated-dependencies:
- dependency-name: sphinx
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@Pixel-Minions @JeanChristopheMorinPerso
Make Powershell correctly return exit codes for aliases (AcademySoftw…
8113ffd 
…areFoundation#1778)

Fixes issue where powershell plugins were not correctly capturing exit codes when aliased commands failed (AcademySoftwareFoundation#1778)

---------

Signed-off-by: brycegbrazen <[email protected]>
Co-authored-by: Jean-Christophe Morin <[email protected]>
@Pixel-Minions
Fix package_cache_async missing from ResolvedContext dict round-t…
591a164 
…rip. Also bumped the serialization formation from 4.7 to 4.8 (AcademySoftwareFoundation#1810)

Signed-off-by: Nathan Rusch <[email protected]>
@Pixel-Minions
Add support for synchronous and asynchronous package caching modes
25ab47a 
- Introduced `--pkg-cache-mode` argument to specify caching mode (`sync` or `async`).
- Updated `add_variant` function to handle the new caching modes.
@Pixel-Minions
Copy link
Contributor Author

@JeanChristopheMorinPerso For review

@JeanChristopheMorinPerso
Copy link
Member

@Pixel-Minions I'm not too sure how you created your branch, but there is a lot of commits that are not from you and DCO fails because of that.

@JeanChristopheMorinPerso JeanChristopheMorinPerso added the Blocked by DCO Waiting on commit signoff label Oct 13, 2024
@JeanChristopheMorinPerso JeanChristopheMorinPerso added this to the Next milestone Oct 13, 2024
@JeanChristopheMorinPerso JeanChristopheMorinPerso changed the title Add support for synchronous and asynchronous package caching modes Add support for synchronous mode in rez-pkg-cache Oct 13, 2024
@JeanChristopheMorinPerso
Copy link
Member

Closing in favor of #1853

@JeanChristopheMorinPerso JeanChristopheMorinPerso removed this from the Next milestone Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Blocked by DCO Waiting on commit signoff
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pixel-Minions @JeanChristopheMorinPerso