Added configuration option to skip invalid packages #1705
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Andersen <[email protected]>
isohedronpipeline
force-pushed
the
ignore_invalid_packages
branch
from
9d793f6 to
6e68a26
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1705 +/- ##
==========================================
- Coverage 58.25% 58.23% -0.02%
==========================================
Files 126 126
Lines 17157 17168 +11
Branches 3504 3506 +2
==========================================
+ Hits 9995 9998 +3
- Misses 6496 6504 +8
Partials 666 666 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a configuration option to continue solving if an invalid or missing package file is found within a package folder.
Missing package files can happen if the package file itself is in git and the branch is changed. Changing branches does not remove empty directories without a clean operation. This can cause rez to break for any resolve.
Similarly, if any package file contains syntax that is not parseable by your version of python, rez will not resolve any environment at all. This can happen if your package files have f strings and you try to do a resolve in a python 2 environment, for example.