#99 examples runner update, scalatest pom update + example test delib…

…erately failing
AbsaOSS · Aug 2, 2021 · 2abd5f3 · 2abd5f3
1 parent 2d27880
commit 2abd5f3
Show file tree

Hide file tree

Showing 4 changed files with 25 additions and 12 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -51,10 +51,9 @@ jobs:
       - name: Build and unit test
         if: ${{ ! contains( github.event.pull_request.labels.*.name, 'NoTestNeeded') }}
         run: mvn clean install --no-transfer-progress -Pspark-${{ matrix.spark }} -Dspan.scale.factor=10
-
-      - name: Switch scala to ${{ matrix.scala }} & build and unit test Atum Examples
+      - name: Build and unit test Atum Examples Scala ${{ matrix.scala }} and Spark ${{ matrix.spark }}
         working-directory: ./examples/atum-examples
         if: ${{ ! contains( github.event.pull_request.labels.*.name, 'NoTestNeeded') }}
         run: |
           mvn scala-cross-build:change-version -Pscala-${{ matrix.scala }}
-          mvn clean install --no-transfer-progress -Pspark-${{ matrix.spark }} -Dspan.scale.factor=10
+          mvn clean install --no-transfer-progress -Pspark-${{ matrix.spark }}
diff --git a/examples/atum-examples/pom.xml b/examples/atum-examples/pom.xml
@@ -19,7 +19,7 @@
     <modelVersion>4.0.0</modelVersion>
 
     <groupId>za.co.absa</groupId>
-    <artifactId>atum-examples_2.11</artifactId>
+    <artifactId>atum-examples_2.12</artifactId>
     <version>0.0.1-SNAPSHOT</version>
 
     <packaging>jar</packaging>
@@ -41,8 +41,8 @@
         <spark.version>${spark-24.version}</spark.version>
 
         <!-- Controlled by `scala-cross-build` plugin -->
-        <scala.version>2.11.12</scala.version>
-        <scala.binary.version>2.11</scala.binary.version>
+        <scala.version>2.12.12</scala.version>
+        <scala.binary.version>2.12</scala.binary.version>
 
         <!-- Build and plugins properties -->
         <scalatest.maven.plugin.version>2.0.2</scalatest.maven.plugin.version>
@@ -140,9 +140,14 @@
                 <groupId>org.scalatest</groupId>
                 <artifactId>scalatest-maven-plugin</artifactId>
                 <version>${scalatest.maven.plugin.version}</version>
-                <configuration>
-                    <skipTests>false</skipTests>
-                </configuration>
+                <executions>
+                    <execution>
+                        <id>test</id>
+                        <goals>
+                            <goal>test</goal>
+                        </goals>
+                    </execution>
+                </executions>
             </plugin>
 
             <!-- Uber jar generation -->

diff --git a/examples/atum-examples/src/main/scala/za/co/absa/atum/examples/SampleMeasurements1.scala b/examples/atum-examples/src/main/scala/za/co/absa/atum/examples/SampleMeasurements1.scala
@@ -55,6 +55,9 @@ object SampleMeasurements1 {
     spark.disableControlMeasuresTracking()
     spark.close()
 
+    // todo remove
+    throw new IllegalStateException("deliberately failing to test gh actions")
+
     if (!Files.exists(Paths.get("data/output/stage1_job_results/_INFO"))) {
       throw new Exception("_INFO file not found at data/output/stage1_job_results")
     } else {

diff --git a/examples/s3-sdk-extension-examples/pom.xml b/examples/s3-sdk-extension-examples/pom.xml
@@ -140,11 +140,17 @@
                 <groupId>org.scalatest</groupId>
                 <artifactId>scalatest-maven-plugin</artifactId>
                 <version>${scalatest.maven.plugin.version}</version>
-                <configuration>
-                    <skipTests>true</skipTests>
-                </configuration>
+                <executions>
+                    <execution>
+                        <id>test</id>
+                        <goals>
+                            <goal>test</goal>
+                        </goals>
+                    </execution>
+                </executions>
             </plugin>
 
+
             <!-- Uber jar generation -->
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>