Detecting Report Changes: further improvements and cleanup

src/domain/report-data.ts

@@ -28,7 +28,7 @@ export class ReportData {
   asHash(): string {
     return crypto
       .createHash('sha256')
-      .update(JSON.stringify(this))
+      .update(JSON.stringify(this.data))
       .digest('hex');
   }
 }

src/report-changes/core/report-changes.service.ts

@@ -107,16 +107,21 @@ export class ReportChangesService {
         continue;
       }
 
-      const reportChangeEventObservable =
-        this.calculateNewReportData(changeDetector);
+      const reportChangeEventObservable = this.calculateNewReportData(
+        changeDetector,
+        docChange,
+      );
 
       affectedReports.push(reportChangeEventObservable);
     }
 
     return zip(affectedReports);
   }
 
-  private calculateNewReportData(changeDetector: ReportChangeDetector) {
+  private calculateNewReportData(
+    changeDetector: ReportChangeDetector,
+    docChange: DocChangeDetails,
+  ) {
     return this.createReportCalculation
       .startReportCalculation(changeDetector.report)
       .pipe(
@@ -132,11 +137,21 @@ export class ReportChangesService {
             new Reference(outcome.result.id),
           );
         }),
-        filter(
-          (calcUpdate) =>
+        filter((calcUpdate) => {
+          if (
             (calcUpdate.outcome as ReportCalculationOutcomeSuccess)
-              ?.result_hash !== changeDetector.lastCalculationHash,
-        ),
+              ?.result_hash !== changeDetector.lastCalculationHash
+          ) {
+            return true;
+          } else {
+            console.log(
+              'Report calculation did not change from doc',
+              changeDetector.report,
+              docChange,
+            );
+            return false;
+          }
+        }),
         tap(
           (calcUpdate) =>
             (changeDetector.lastCalculationHash = (