This repository has been archived by the owner on Mar 14, 2024. It is now read-only.
Notification endpoints #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/app.module.ts # src/couchdb/dtos.ts # src/domain/report-data-change-event.ts # src/domain/report.ts # src/notification/core/notification.service.ts # src/notification/notification.module.ts # src/report-changes/core/report-change-detector.spec.ts # src/report-changes/core/report-changes.service.ts # src/report-changes/report-changes.module.ts # src/report/report.module.ts # src/report/storage/report-storage.service.ts
sleidig
force-pushed
the
notification-endpoints
branch
from
ded8c3e to
d4641b9
Compare
sleidig
commented
Feb 19, 2024
sleidig
commented
Feb 19, 2024
There was a problem hiding this comment.
Nice cleanup with the last commit, @tomwwinter 👍
Can you look also at the remaining comments from my last review and commit/resolve or mark as resolved?
I can't approve (as I opened the PR originally) but this looks mostly good to go from a code review. (didn't do functional testing)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #15
based on PR #17 ; maybe merge an initial, rough version of that other PR first?