feat: support for sql reports without date range #2502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deployed to https://pr-2502.aam-digital.net/ |
sleidig
approved these changes
Aug 7, 2024
src/app/features/reporting/reporting/select-report/select-report.component.spec.ts
Show resolved
Hide resolved
src/app/features/reporting/reporting/select-report/select-report.component.spec.ts
Outdated
Show resolved
Hide resolved
src/app/features/reporting/reporting/select-report/select-report.component.spec.ts
Outdated
Show resolved
Hide resolved
src/app/features/reporting/reporting/select-report/select-report.component.spec.ts
Outdated
Show resolved
Hide resolved
src/app/features/reporting/reporting/select-report/select-report.component.ts
Show resolved
Hide resolved
sleidig
approved these changes
Aug 8, 2024
There was a problem hiding this comment.
From testing on https://dev.aam-digital.net :
- Report without args (--> e.g. "Beneficiary (Individuals) [SQL]")
- hides period time picker as expected
- shows results
- Report with args (--> e.g. "Event Participants Report [SQL]")
- shows period time picker as expected
- shows result
- Report with broken query config
- shows error message as expected
It can feel like reports are failing / endlessly calculating if the backend is still processing other changes. (see Aam-Digital/aam-services#4 ), in real-life scenarios this could become a serious issue.
|
🎉 This PR is included in version 3.40.0-master.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 3.40.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #2463
Visible/Frontend Changes