Skip to content

Commit

Permalink
chore: apply prettier rules (#2371)
Browse files Browse the repository at this point in the history
* fix: improve sentry logging

* chore: apply prettier rules on all files
  • Loading branch information
tomwwinter authored Apr 30, 2024
1 parent 9a8bdb4 commit 6c8958c
Show file tree
Hide file tree
Showing 87 changed files with 937 additions and 647 deletions.
16 changes: 11 additions & 5 deletions .eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -40,20 +40,26 @@
"*.html"
],
"extends": [
"plugin:@angular-eslint/template/recommended"
"plugin:@angular-eslint/template/recommended",
"plugin:prettier/recommended"
],
"rules": {}
}, {
"files": ["*.stories.@(ts|tsx|js|jsx|mjs|cjs)"],
},
{
"files": [
"*.stories.@(ts|tsx|js|jsx|mjs|cjs)"
],
"rules": {
"storybook/story-exports": "off"
}
}
],
"rules": {
"prettier/prettier": "error"
"prettier/prettier": "error"
},
"plugins": ["prettier"],
"plugins": [
"prettier"
],
"extends": [
"plugin:storybook/recommended",
"prettier"
Expand Down
15 changes: 8 additions & 7 deletions .github/ISSUE_TEMPLATE/bug_report.md
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
---
name: Bug report
about: Report a problem
title: ''
labels: 'Type: Bug'
assignees: ''

title: ""
labels: "Type: Bug"
assignees: ""
---

**Describe the bug**
A clear and concise description of what the bug is.

**To Reproduce**
Steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
Expand All @@ -24,9 +24,10 @@ A clear and concise description of what you expected to happen.
If applicable, add screenshots to help explain your problem.

**Desktop (please complete the following information):**
- OS: [e.g. iOS]
- Browser [e.g. chrome, safari]
- Version [e.g. 22]

- OS: [e.g. iOS]
- Browser [e.g. chrome, safari]
- Version [e.g. 22]

**Additional context**
Add any other context about the problem here.
8 changes: 3 additions & 5 deletions .github/ISSUE_TEMPLATE/empty.md
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
---
name: Blank issue
about: Any other issue not fitting the specific templates
title: ''
labels: ''
assignees: ''

title: ""
labels: ""
assignees: ""
---

9 changes: 4 additions & 5 deletions .github/ISSUE_TEMPLATE/feature_request.md
Original file line number Diff line number Diff line change
@@ -1,13 +1,12 @@
---
name: Feature request
about: Suggest an idea for this project
title: ''
labels: 'Priority: Idea, Type: Feature'
assignees: ''

title: ""
labels: "Priority: Idea, Type: Feature"
assignees: ""
---

*As a [type of user] I want to [...] in order to [achieve XY goal].*
_As a [type of user] I want to [...] in order to [achieve XY goal]._
A short summary of the feature: Who would use this new feature? And what is the objective or use case in real life?

**Objective**
Expand Down
10 changes: 6 additions & 4 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
closes: #XX

### Visible/Frontend Changes
- [x]
- [ ]

- [x]
- [ ]

### Architectural/Backend Changes
- [x]
- [ ]

- [x]
- [ ]
4 changes: 2 additions & 2 deletions .github/workflows/percy.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: Percy
on:
pull_request:
types: [ opened, synchronize, reopened, ready_for_review ]
types: [opened, synchronize, reopened, ready_for_review]
push:
branches:
- master
Expand All @@ -15,7 +15,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: '16'
node-version: "16"
cache: npm
- run: npm ci
- run: npm run percy-storybook
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pull-request-closed.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: CleanUp
on:
pull_request_target:
types: [ closed ]
types: [closed]

jobs:
remove-deployment:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pull-request-opened.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ permissions:

on:
pull_request:
types: [ opened, reopened ]
types: [opened, reopened]

jobs:
create-deployment:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/tagged-commit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: New Tag
on:
push:
tags:
- '*'
- "*"

jobs:
publish-image:
Expand Down
12 changes: 9 additions & 3 deletions .prettierrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,19 @@
{
"files": "*.html",
"options": {
"parser": "html"
"parser": "angular"
}
},
{
"files": "*.component.html",
"files": "*.scss",
"options": {
"parser": "angular"
"parser": "scss"
}
},
{
"files": "*.json",
"options": {
"parser": "json-stringify"
}
}
]
Expand Down
20 changes: 13 additions & 7 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1,41 +1,47 @@
# Welcome!

_Aam Digital_ is open source because we believe in building things together
and letting people benefit from and adapt things rather than everybody reinventing their own wheel.

In order to build great software for small social impact organisations
we welcome anybody willing to contribute.
We are a small core team of full-time developers as well as a few regular volunteer contributors.
So whether you want to extend our code for your own use case or just help out -
So whether you want to extend our code for your own use case or just help out -
we welcome any contributions to make this project better!

-----
---

## Get started

To get started, please have a look at our [Developer Documentation](https://aam-digital.github.io/ndb-core/documentation/additional-documentation/overview.html).

1. Work through the [Tutorial](https://aam-digital.github.io/ndb-core/documentation/additional-documentation/tutorial.html).
* This walks you through the setup and basic understanding of the project and also gives an overview of the technologies and frameworks involved.
* Feel free to skip over steps that seem trivial to you, we tried to make this very beginner friendly.
- This walks you through the setup and basic understanding of the project and also gives an overview of the technologies and frameworks involved.
- Feel free to skip over steps that seem trivial to you, we tried to make this very beginner friendly.
2. Check our workflow regarding pull requests: [How to contribute code](https://aam-digital.github.io/ndb-core/documentation/additional-documentation/how-to-guides/contribute-code-to-the-project.html)
3. Don't hesitate to ask questions!

## Get in touch

Do get in touch with us by creating an issue here or
writing to [[email protected]](mailto:[email protected]).

Our main communication channels in the team are
* **GitHub issues** and **pull requests**.
Feel free to open one yourself also to ask a question.
* **Slack**. Write us an e-mail to get an invitation to our workspace.

- **GitHub issues** and **pull requests**.
Feel free to open one yourself also to ask a question.
- **Slack**. Write us an e-mail to get an invitation to our workspace.

## Where can I help?

Have a look at our issues on GitHub.
Some of them are explicitly label as suitable issues for a new contributor to work on: [Community Help Wanted](https://github.com/orgs/Aam-Digital/projects/2/views/4?filterQuery=label%3A%22Status%3A+Community+Help+Wanted+%28good+first+issue%29%22+).
If you are not sure whether you should work on a certain issue, just post a short comment in the issue to clarify.

Whenever you start working on an issue, please assign yourself on the GitHub issue and change the "status" within the project to "In Progress".

We organize our work using GitHub Projects' kanban boards and issue labels:

- [Project Board](https://github.com/orgs/Aam-Digital/projects/2)
- Get an overview of all issues (across all repositories) and their status here, we use a kanban-style board where issues are moved through the columns based on their status.
- The issues in the board are sorted by priority (most important on top).
Expand Down
Loading

0 comments on commit 6c8958c

Please sign in to comment.