fix(public forms): correct permission checks to allow unauthenticated…

… users access to forms again (#2700)

src/app/core/permissions/ability/ability.service.ts

@@ -92,6 +92,10 @@ export class AbilityService extends LatestEntityLoader<Config<DatabaseRules>> {
     rules: DatabaseRule[],
   ): Promise<DatabaseRule[]> {
     const sessionInfo: SessionInfo = this.sessionInfo.value;
+    if (!sessionInfo) {
+      // for unauthenticated users, no user variables are available and interpolated
+      return rules;
+    }
 
     const user = await firstValueFrom(
       // only emit once user entity is loaded (or "null" for user account without entity)

src/app/features/public-form/public-form.component.ts

@@ -12,7 +12,6 @@ import {
 import { EntityFormComponent } from "../../core/common-components/entity-form/entity-form/entity-form.component";
 import { MatButtonModule } from "@angular/material/button";
 import { ConfigService } from "../../core/config/config.service";
-import { EntitySchemaService } from "../../core/entity/schema/entity-schema.service";
 import { MatSnackBar } from "@angular/material/snack-bar";
 import { MatCardModule } from "@angular/material/card";
 import { UntilDestroy, untilDestroyed } from "@ngneat/until-destroy";
@@ -43,7 +42,6 @@ export class PublicFormComponent<E extends Entity> implements OnInit {
     private entityMapper: EntityMapperService,
     private entityFormService: EntityFormService,
     private configService: ConfigService,
-    private entitySchemaService: EntitySchemaService,
     private snackbar: MatSnackBar,
   ) {}
 
@@ -139,14 +137,9 @@ export class PublicFormComponent<E extends Entity> implements OnInit {
 
   private async initForm() {
     this.entity = new this.entityType();
-    this.entityFormService
-      .createEntityForm(
-        [].concat(...this.fieldGroups.map((group) => group.fields)),
-        this.entity,
-      )
-      .then((value) => {
-        this.form = value;
-        const formControls = this.form.formGroup.controls;
-      });
+    this.form = await this.entityFormService.createEntityForm(
+      [].concat(...this.fieldGroups.map((group) => group.fields)),
+      this.entity,
+    );
   }
 }