Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: skillLab integration #52
base: main
Are you sure you want to change the base?
feat: skillLab integration #52
Changes from all commits
6173e87
8626807
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am a bit lost here, looking at this as a new dev. Do we have any description about how the roles are used and mapped for us?
Is the "aam_" added internally or already do be defined in the Keycloak roles?
How to use the
@PreAuthorize("hasAuthority('ROLE_aam_skill_admin')")
in the following files: which parts are hard prefixes and which ones the name of the role in Keycloak? (Maybe we could have one annotation to check exactly against a keycloak role name to make this easier to understand?)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"aam_skill_admin" is the name of the role in the token and in Keycloak. The "ROLE_" prefix is an spring boot convention, not really necessary.