feat: add export template api #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sleidig
reviewed
Sep 12, 2024
There was a problem hiding this comment.
Looks quite good and clean! Just a few remarks regarding naming and comments for easier understanding of the code.
Nice test coverage also!
- update README with a short section on the feature + setup instructions
- add open-api specs file for our endpoints
- naming of the endpoint + module (export reminds me more of csv exports ... but I understand the intention behind this also ...)
...m-backend-service/src/main/kotlin/com/aamdigital/aambackendservice/auth/core/AuthProvider.kt
Outdated
Show resolved
Hide resolved
...d-service/src/main/kotlin/com/aamdigital/aambackendservice/auth/core/KeycloakAuthProvider.kt
Show resolved
Hide resolved
...c/main/kotlin/com/aamdigital/aambackendservice/export/controller/TemplateExportController.kt
Show resolved
Hide resolved
...c/main/kotlin/com/aamdigital/aambackendservice/export/controller/TemplateExportController.kt
Outdated
Show resolved
Hide resolved
...ckend-service/src/main/kotlin/com/aamdigital/aambackendservice/export/core/ExportTemplate.kt
Outdated
Show resolved
Hide resolved
.../main/kotlin/com/aamdigital/aambackendservice/export/usecase/DefaultRenderTemplateUseCase.kt
Outdated
Show resolved
Hide resolved
...t/kotlin/com/aamdigital/aambackendservice/export/usecase/DefaultRenderTemplateUseCaseTest.kt
Outdated
Show resolved
Hide resolved
...t/kotlin/com/aamdigital/aambackendservice/export/usecase/DefaultRenderTemplateUseCaseTest.kt
Show resolved
Hide resolved
application/aam-backend-service/src/test/resources/cucumber/features/export/export.feature
Outdated
Show resolved
Hide resolved
sleidig
approved these changes
Sep 17, 2024
.../main/kotlin/com/aamdigital/aambackendservice/export/usecase/DefaultCreateTemplateUseCase.kt
Outdated
Show resolved
Hide resolved
sleidig
reviewed
Sep 17, 2024
…/aambackendservice/export/usecase/DefaultCreateTemplateUseCase.kt Co-authored-by: Sebastian <[email protected]>
Co-authored-by: Sebastian <[email protected]>
Co-authored-by: Sebastian <[email protected]>
Co-authored-by: Sebastian <[email protected]>
Co-authored-by: Sebastian <[email protected]>
Co-authored-by: Sebastian <[email protected]>
Co-authored-by: Sebastian <[email protected]>
Co-authored-by: Sebastian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.