Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add e2e test scenarios #13

Merged
merged 52 commits into from
Apr 15, 2024
Merged

test: add e2e test scenarios #13

merged 52 commits into from
Apr 15, 2024

Conversation

tomwwinter
Copy link
Contributor

@tomwwinter tomwwinter commented Mar 20, 2024

Closes #8
Closes #6

@tomwwinter tomwwinter self-assigned this Mar 20, 2024
Copy link

Overall Project 16.78%
File Coverage
ReportController.kt 30.46% 🍏
ReportCalculationController.kt 7.32% 🍏
AamException.kt 0% 🍏

Copy link

Overall Project 16.78%
File Coverage
ReportController.kt 30.46% 🍏
ReportCalculationController.kt 7.32% 🍏
AamException.kt 0% 🍏

Copy link

Overall Project 16.78%
File Coverage
ReportController.kt 30.46% 🍏
ReportCalculationController.kt 7.32% 🍏
AamException.kt 0% 🍏

Copy link

Overall Project 16.78%
File Coverage
ReportController.kt 30.46% 🍏
ReportCalculationController.kt 7.32% 🍏
AamException.kt 0% 🍏

Copy link

Overall Project 16.78%
File Coverage
ReportController.kt 30.46% 🍏
ReportCalculationController.kt 7.32% 🍏
AamException.kt 0% 🍏

Copy link

Overall Project 16.78%
File Coverage
ReportController.kt 30.46% 🍏
ReportCalculationController.kt 7.32% 🍏
AamException.kt 0% 🍏

Copy link

github-actions bot commented Mar 21, 2024

Code Coverage Analyse

Overall Project 34.82%
Files changed 100% 🍏

File Coverage
ReportRepository.kt 100% 🍏
ReportController.kt 94.25% 🍏
ReportCalculationController.kt 94.15% 🍏
SecurityConfiguration.kt 91.94% 🍏
ReportData.kt 91.36% 🍏
DefaultReportingStorage.kt 79.57% 🍏
ReportCalculation.kt 64.44% 🍏
ReportCalculationRepository.kt 62.77% 🍏
AamException.kt 33.19% 🍏

@tomwwinter tomwwinter marked this pull request as ready for review March 22, 2024 07:51
@tomwwinter tomwwinter requested a review from sleidig March 22, 2024 07:51
Copy link
Member

@sleidig sleidig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice structure, this looks easy to understand and easy to add more test scenarios 👍

Is there a code-climate plugin for test coverage for this, similar to what we have in ndb-core? Would be neat to see it as github PR checks (and track it in code-climate) instead of the multiple bot comments 😊

A ton of e2e test scenarios are still missing of course. Shall we create a separate issue for these?
(creating calculations, getting actual data calculated by sqs and all the webhook parts are critically to get tested ASAP)

@tomwwinter tomwwinter merged commit 77b7574 into main Apr 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

e2e and API spec tests add test coverage and other checks to PRs / CI
2 participants