Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added min_height as cli option #133

Closed
wants to merge 2 commits into from
Closed

Added min_height as cli option #133

wants to merge 2 commits into from

Conversation

mohamedleithy
Copy link
Collaborator

  • Added min_height cli option

Resolves #122

@mohamedleithy mohamedleithy requested a review from donn February 15, 2022 08:11
@antonblanchard
Copy link
Contributor

Thanks, I've tested this with a small RAM and it looks good. FYI the short option overlaps the halo option.

@mohamedleithy
Copy link
Collaborator Author

@antonblanchard
Thanks for letting me know. I've submitted a new pull request to centralize the core in the die, and have dedicated "-H" for the min_height option. Please check it out. 😊

@donn
Copy link
Member

donn commented Feb 22, 2022

Superseded by #136.

@donn donn closed this Feb 22, 2022
@donn donn deleted the adding-minimum-height branch February 23, 2022 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donn donn Awaiting requested review from donn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Small RAMs might not intersect all met5 power rails
3 participants
@mohamedleithy @antonblanchard @donn