Skip to content

Commit

Permalink
switch back to spot for multi-burst insar
Browse files Browse the repository at this point in the history
  • Loading branch information
jtherrmann committed Dec 20, 2024
1 parent a9c2e6f commit 0e5958b
Show file tree
Hide file tree
Showing 5 changed files with 4 additions and 93 deletions.
1 change: 0 additions & 1 deletion .github/workflows/deploy-multi-burst-sandbox.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ jobs:
job_files: >-
job_spec/INSAR_ISCE_BURST.yml
job_spec/INSAR_ISCE_MULTI_BURST.yml
job_spec/INSAR_ISCE_MULTI_BURST_SPOT.yml
instance_types: r6id.xlarge,r6id.2xlarge,r6id.4xlarge,r6id.8xlarge,r6idn.xlarge,r6idn.2xlarge,r6idn.4xlarge,r6idn.8xlarge
default_max_vcpus: 640
expanded_max_vcpus: 640
Expand Down
4 changes: 1 addition & 3 deletions apps/set-batch-overrides/src/set_batch_overrides.py
Original file line number Diff line number Diff line change
Expand Up @@ -65,9 +65,7 @@ def get_insar_isce_burst_memory(job_parameters: dict) -> str:
def lambda_handler(event: dict, _) -> dict:
job_type, job_parameters = event['job_type'], event['job_parameters']

# TODO revert
#if job_type == 'INSAR_ISCE_MULTI_BURST':
if job_type in ('INSAR_ISCE_MULTI_BURST', 'INSAR_ISCE_MULTI_BURST_SPOT'):
if job_type == 'INSAR_ISCE_MULTI_BURST':
memory = get_insar_isce_burst_memory(job_parameters)
omp_num_threads = INSAR_ISCE_BURST_OMP_NUM_THREADS[memory]
return get_container_overrides(memory, omp_num_threads)
Expand Down
6 changes: 3 additions & 3 deletions job_spec/INSAR_ISCE_MULTI_BURST.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ INSAR_ISCE_MULTI_BURST:
api_schema:
type: array
minItems: 1
maxItems: 30 # TODO limit based on Spot failure rate?
maxItems: 15
# TODO: provide an example with multiple bursts
example:
- S1_136231_IW2_20200604T022312_VV_7C85-BURST
Expand All @@ -22,7 +22,7 @@ INSAR_ISCE_MULTI_BURST:
api_schema:
type: array
minItems: 1
maxItems: 30 # TODO limit based on Spot failure rate?
maxItems: 15
example:
- S1_136231_IW2_20200616T022313_VV_5D11-BURST
items:
Expand Down Expand Up @@ -75,7 +75,7 @@ INSAR_ISCE_MULTI_BURST:
- --secondary
- Ref::secondary
timeout: 126000 # 35 hours
compute_environment: InsarIsceMultiBurst
compute_environment: Default
vcpu: 1
memory: 4 # Memory is always overridden by the step function
secrets:
Expand Down
83 changes: 0 additions & 83 deletions job_spec/INSAR_ISCE_MULTI_BURST_SPOT.yml

This file was deleted.

3 changes: 0 additions & 3 deletions job_spec/config/compute_environments.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,3 @@ compute_environments:
InsarIsceAria:
allocation_type: EC2
allocation_strategy: BEST_FIT_PROGRESSIVE
InsarIsceMultiBurst:
allocation_type: EC2
allocation_strategy: BEST_FIT_PROGRESSIVE

0 comments on commit 0e5958b

Please sign in to comment.