-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check user is whitelisted after authentication #275
Conversation
src/hyp3_sdk/hyp3.py
Outdated
info = self.my_info() | ||
if info['application_status'] != 'APPROVED': | ||
warnings.warn(f'User {info["user_id"]} has not yet applied for a monthly credit allotment.' | ||
' Please visit https://hyp3.asf.alaska.edu/request_access to submit your application.') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will https://hyp3.asf.alaska.edu/request_access be the correct link?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're aiming for https://hyp3-docs.asf.alaska.edu/using/requesting_access
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The warning message(s) can match the error message(s) we implemented in HyP3 at https://github.com/ASFHyP3/hyp3/blob/develop/lib/dynamo/dynamo/exceptions.py#L19 for not started/pending/rejected
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@asjohnston-asf so would you suggest different warning messages for no submitted application, pending application, and rejected?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you like. I documented them as stretch goals in the comments for TOOL-2740, but I'm not going to insist if you don't think it's worth the effort.
No description provided.