Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly support python 3.9->3.12 #242

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Explicitly support python 3.9->3.12 #242

merged 1 commit into from
Nov 2, 2023

Conversation

jhkennedy
Copy link
Contributor

No description provided.

@jhkennedy jhkennedy requested a review from a team as a code owner November 1, 2023 21:13
jtherrmann
jtherrmann reviewed Nov 1, 2023
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
jtherrmann
jtherrmann previously approved these changes Nov 1, 2023
View reviewed changes
@jtherrmann jtherrmann dismissed their stale review November 1, 2023 21:18

some other places need to be updated

jtherrmann
jtherrmann requested changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@jtherrmann jtherrmann left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll also need to update environment.yml. Also, does the version field in the Jupyter notebooks under docs/ need to be updated? (I just ran a git grep '3\.8'.)

@jhkennedy
Copy link
Contributor Author

@jtherrmann I updated environment.yml. The version field in the notebooks is just metadata recorded in the notebook about the Python version when it was run and checked into the repo. I don't see a need to update it, and it's not something you can every really see. It is possible to strip, albeit annoying to do so.

jhkennedy
jhkennedy commented Nov 1, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
jhkennedy
jhkennedy commented Nov 1, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@jhkennedy jhkennedy requested a review from jtherrmann November 1, 2023 21:32
@jhkennedy jhkennedy merged commit ec72fcd into develop Nov 2, 2023
8 checks passed
@jhkennedy jhkennedy deleted the jhkennedy-patch-1 branch November 2, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtherrmann jtherrmann jtherrmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhkennedy @jtherrmann