Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Job.subscription_id attribute #233

Merged
merged 1 commit into from
Sep 1, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [PEP 440](https://www.python.org/dev/peps/pep-0440/)
and uses [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [3.0.0]
### Removed
* Removed the `Job.subscription_id` attribute in response to the Subscriptions feature being removed from HyP3.

## [2.1.1]
### Fixed
* The `user_id` parameter has been moved to the end of the `HyP3.find_jobs` parameter list, to avoid
Expand Down
3 changes: 0 additions & 3 deletions src/hyp3_sdk/jobs.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ def __init__(
request_time: datetime,
status_code: str,
user_id: str,
subscription_id: Optional[str] = None,
name: Optional[str] = None,
job_parameters: Optional[dict] = None,
files: Optional[List] = None,
Expand All @@ -38,7 +37,6 @@ def __init__(
self.request_time = request_time
self.status_code = status_code
self.user_id = user_id
self.subscription_id = subscription_id
self.name = name
self.job_parameters = job_parameters
self.files = files
Expand Down Expand Up @@ -66,7 +64,6 @@ def from_dict(input_dict: dict):
request_time=parse_date(input_dict['request_time']),
status_code=input_dict['status_code'],
user_id=input_dict['user_id'],
subscription_id=input_dict.get('subscription_id'),
name=input_dict.get('name'),
job_parameters=input_dict.get('job_parameters'),
files=input_dict.get('files'),
Expand Down
Loading