Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#319 [feat] 기존 시간 입력 로직 제거 #325

Merged
merged 9 commits into from
Aug 25, 2024
Merged

#319 [feat] 기존 시간 입력 로직 제거 #325

merged 9 commits into from
Aug 25, 2024

Conversation

KWY0218
Copy link
Member

@KWY0218 KWY0218 commented Aug 24, 2024

✒️ 관련 이슈번호

Key Changes 🔑

  1. 내용
    • 기존 시간 입력 로직 제거
    • 중복된 시간이 있는지 검사하는 로직은 시간과 관련되어있다고 판단하여 UserMeetingScheduleService로 옮겼습니다.
    • 옮기기 전 테스트 코드를 작성한 후, 리팩토링을 진행했습니다.

@KWY0218 KWY0218 requested a review from sohyundoh August 24, 2024 15:53
@KWY0218 KWY0218 self-assigned this Aug 24, 2024
Copy link
Member

@sohyundoh sohyundoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!

혹시 서비스가 삭제되면서 사용되지 않는 record builder 어노테이션도 지워주실 수 있을까요?

@KWY0218
Copy link
Member Author

KWY0218 commented Aug 25, 2024

@sohyundoh

혹시 AvailableDatesDto , TimeTableResponseDto 이 2개가 맞을까요??

다음부터는 어떤 dto도 같이 알려주시면 찾을 때 수월할 것 같습니다..! 😭😭

@sohyundoh
Copy link
Member

앗 죄송합니다!!
AvailableDatesDto, TimeSlotDto, TimeTableResponseDto 이렇게 세가지 입니다!
감사합니다!!

@KWY0218 KWY0218 merged commit 5189eaa into develop Aug 25, 2024
4 checks passed
@KWY0218 KWY0218 deleted the feat/#319 branch August 25, 2024 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat] 기존 시간 입력 로직 없애기
2 participants