Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#270 [feat] Prefer time 관련 로직 삭제 #287

Merged
merged 4 commits into from
Jul 29, 2024
Merged

#270 [feat] Prefer time 관련 로직 삭제 #287

merged 4 commits into from
Jul 29, 2024

Conversation

sohyundoh
Copy link
Member

@sohyundoh sohyundoh commented Jul 22, 2024 •
edited
Loading

✒️ 관련 이슈번호

Key Changes 🔑

  1. 기존에 있던 Prefer Time 로직을 삭제했습니다!
  2. 회의 생성 API 와 회의 선택지 제공 API 둘 다 수정했습니다!(웹과 논의 거쳤습니다! 참고 : https://asap-evv2603.slack.com/archives/C05DGU9SB43/p1721656215057269)
  3. 테스트 코드에서 회의 생성을 하고 있었던 코드를 수정하였습니다!

To Reviewers 📢

  • 테스트 코드를 작성하려고 하는데, MockMvc 사용해서 컨트롤러 단위테스트를 작성하는 것에 대해서 어떻게 생각하시나요!?

@sohyundoh sohyundoh added the High label Jul 22, 2024
@sohyundoh sohyundoh requested a review from KWY0218 July 22, 2024 14:14
@sohyundoh sohyundoh self-assigned this Jul 22, 2024
@KWY0218
Copy link
Member

KWY0218 commented Jul 23, 2024

테스트 코드는 환영합니다 ^_^
또, 다음엔 이런 논의는 슬랙 웹-서 채널에서 하면 좋을 것 같습니다~!

@KWY0218 KWY0218 merged commit 69d6649 into develop Jul 29, 2024
4 checks passed
@KWY0218 KWY0218 deleted the feat/#270 branch July 29, 2024 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KWY0218 KWY0218 Awaiting requested review from KWY0218

Assignees

@sohyundoh sohyundoh

Labels
High
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[fix] 회의 생성 시 prefer time 06~24시로 고정
2 participants
@sohyundoh @KWY0218