Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#238 [refactor] 회의 ID 디코딩 로직 리팩토링 #239

Merged
merged 2 commits into from
Nov 19, 2023
Merged

Conversation

KWY0218
Copy link
Member

@KWY0218 KWY0218 commented Nov 17, 2023

✒️ 관련 이슈번호

Key Changes 🔑

  1. 내용
    • 회의 ID 디코딩 로직 리팩토링

To Reviewers 📢

  • 굳이 PathVariable을 상속 받지 않아도, HandlerMethodArgumentResolver를 통해서 구현이 가능했었네요...
  • 이전에 안됐던 이유는 @MeetingId@PathVariable 을 동시에 사용했기 때문에 안되던 것이었네요 하하..

final Map<String, String> pathVariables = (Map<String, String>) request.getAttribute(HandlerMapping.URI_TEMPLATE_VARIABLES_ATTRIBUTE);
를 통해서 URI의 Path 값을 Map 형태로 전달 받습니다.
만약 test/{path1}/{path2}/{path3} 라면, path1: value1, path2: value2, path3: value3 형태의 Key Value 형식으로 반환 받습니다.
그래서 꼭!! 해당 Resolver를 사용할 때에는 URI Path 값을 meetingId 로 해야 된다는 점..!!! 참고해주세요~!

@KWY0218 KWY0218 requested a review from sohyundoh November 17, 2023 12:34
@KWY0218 KWY0218 self-assigned this Nov 17, 2023
Copy link
Member

@sohyundoh sohyundoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

우와 고생하셨습니다!
직접 본게 아니라 차이점을 설명을 들어야할 것 같은데...! 월요일에 들을게요?

@KWY0218
Copy link
Member Author

KWY0218 commented Nov 18, 2023

@sohyundoh
넵 알겠습니다 ~ !

@KWY0218 KWY0218 merged commit da46b0f into develop Nov 19, 2023
1 check passed
@KWY0218 KWY0218 deleted the feat/#238 branch November 19, 2023 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[refactor] 회의 id 디코딩 자동화 로직 리팩토링
2 participants