-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing metadata #11
Fixing metadata #11
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,18 +1,48 @@ | ||
name: 'The name of your action here' | ||
description: 'Provide a description here' | ||
author: 'Your name or organization here' | ||
name: 'dependabot-tickets' | ||
description: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I didn't even notice this file before. |
||
'This action creates a FogBugz and AgilePlace Planview ticket for Dependabot pull requests.' | ||
author: 'Ankura Consulting Group, LLC' | ||
|
||
# Define your inputs here. | ||
inputs: | ||
milliseconds: | ||
description: 'Your input description here' | ||
fogbugz_api_url: | ||
description: 'The URL of your FogBugz API' | ||
required: true | ||
default: '1000' | ||
fogbugz_token: | ||
description: 'Your FogBugz API token' | ||
required: true | ||
fogbugz_project: | ||
description: 'The name of your FogBugz Project' | ||
required: true | ||
fogbugz_category: | ||
description: 'The name of your FogBugz Category' | ||
required: true | ||
planview_api_url: | ||
description: 'The URL of your Planview API' | ||
required: true | ||
planview_auth: | ||
description: 'Your Planview API token' | ||
required: true | ||
planview_board_id: | ||
description: 'The ID of your Planview Board' | ||
required: true | ||
planview_lane_id: | ||
description: 'The ID of your Planview Lane to put the tickets' | ||
required: true | ||
planview_type_id: | ||
description: 'The type of ticket to create' | ||
required: true | ||
users: | ||
description: 'The user making the pull request. Set to "dependabot"' | ||
required: true | ||
default: 'dependabot' | ||
|
||
# Define your outputs here. | ||
outputs: | ||
time: | ||
description: 'Your output description here' | ||
fogbugz_id: | ||
description: 'The FogBugz case number created' | ||
planview_id: | ||
description: 'The Planview ticket id created' | ||
|
||
runs: | ||
using: node20 | ||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -29,15 +29,15 @@ class PlanviewClient { | |
} | ||
|
||
#parseResponse(result) { | ||
if (result.status === 200 && !!result.data.id) { | ||
if (result.status === 201 && !!result.data.id) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this was causing it to return the else condition to the Action runner so it was falling even though the ticket was created. |
||
return { | ||
success: true, | ||
data: result.data | ||
} | ||
} else { | ||
return { | ||
success: false, | ||
result | ||
data: result.data | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think result was causing an error because the Axios response is circular. |
||
} | ||
} | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure how to integration test the action without real endpoints.