Add DataGridExtensionFunctionalTest #983
Conversation
|
My bad, I didn't test on symfony 2.* branches. I will fix it and the default locale problem |
|
@APY/collaborators are you ok with that ? |
There was a problem hiding this comment.
I will not provide a technical review as I literally don't know what @hmert is doing: he's one of the maintainer but he'll keep to be uncommunicative with all contributors.
My impression is that every PR is accepted and this bundle, due to this fact, could become quickly a huge mess.
I would like to have a major commitment of everyone on this project otherwise this is going to die imho.
Tests/app/CompilerPass.php
Outdated
| @@ -0,0 +1,27 @@ | |||
| <?php | |||
| /** | |||
Tests/app/CompilerPass.php
Outdated
| { | ||
|
|
||
| /** | ||
| * You can modify the container here before it is dumped to PHP code. |
| ); | ||
| } | ||
|
|
||
| /** |
| } | ||
|
|
||
|
|
||
| /** |
| use Symfony\Component\Routing\RouterInterface; | ||
|
|
||
| /** | ||
| * Class DataGridExtensionFunctionalTest. |
|
@plfort maybe is better to squash everything in one commit? |
Drop travis tests on 2.7 because of "shared" attribute in service container definitions Fix test AppKernel for symfony 2.8 Set default locale to en-US Remove useless comment/use statements Format code
plfort
force-pushed
the
test-improvement-twigextension
branch
from
b09de60
to
46433ba
Compare
|
@DonCallisto is it ok for you ? |
|
As I told, it's fine conceptually; I did not check it technically as I'm still waiting for an answer from @hmert |
|
@DonCallisto Hi,
I don't agree. As you know, 2.x was returned to life from last years contributions. At that point, those who opened PR's has issues but want to use this bundle. We should help them because except few, everyone has lost enthusiasm to use/contribute. The owner has tried to answering questions. Like us.
Our team was not full time dedicated to maintain this project, like you. So a limited time everyone should have a commitment. On the other hand this project will die or not, being maintained does not mean to be died. It will/should evolve. I want to thank all contributors. But this project completely should change its infrastructure. A complete rewrite progress is long and needs commitment. The issue was that we are not a community, yet. |
|
Hi @hmert Starting with
First of all, approving a PR is not about testing, it's about code review. Second, the minimum test coverage is not reached yet so it's virtually impossible to say if something is good or not without looking the code and trusting only travis. I've never seen a coding standard applied, never seen a rejection or a discussion for one improvement. Never.
I don't disagree with this. I strongly disagree with this. Since I'm a contributor of this bundle, you and the others disappear from there. No one tag an issue, no one reply to an issue or close it as invalid, no one coordinate, no one answer (I've tagged you and other collaborators more than once and never got a reply). Please, take a look to issues, PR(s) and others since one year: I'm the only one, along with @AlessandroMinoccheri that helped me with tests, that has done an active work on this bundle. You didn't.
That's not a point at all, sorry. New owners should be more active than previous one, otherwise no improvements will be reached.
I don't dedicate my full time on this, but my free time. You're not full time on this, neither free time: in last year you were not on the project at all.
Yes it will die as soon as people starts to abandon it. It dies if someone would like to use it but see that this is a one developer bundle, see that there's a lot of issues, there's not a commitment by a community; he/she will never start using this bundle.
That's the only point I agree. If you really believe that we need to become a community, you and all collaborators should improve their efforts. So, if your commitment in this is limited to what you have done in last year, please, try to find new maintainers. |
|
@DonCallisto I'm here to make something better as you, not better then you. I do my best so far. You could blame it all on me, It's OK. If it will help, I could step down, now. |
|
@hmert I'm not here to claim that you should do better than me, or dedicate more time than me. I'm not here to say that I've done more than you. I'm just here to say that you, as the maintainer of this bundle, should be more present than "approving PR". Don't be mad at me, I'm not accusing you; I do know that everyone is involved with its time but to be "vanish" for an entire year without answering to tags in issue and this kind of things is a huge signal that something is not working. |
No description provided.