Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Seo #81

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Seo #81

wants to merge 5 commits into from

Conversation

trevorsmithbanjo
Copy link
Collaborator

No description provided.

@trevorsmithbanjo
Creates New Seo Component w/ useStaticQuery.
0ce7b28
@trevorsmithbanjo
Adds Social Media Functionality to New Seo Component.
029dfbf
@trevorsmithbanjo
Site Metadata Renders On Build.
c4296a7
@trevorsmithbanjo
Replaces Old Seo Component w/ Refactored One.
0583c4a 
Everything appears to be working when I view the site meta data. We will need to deploy the site with this new Seo component in order to run a test on it.
@stephenlprice stephenlprice added the enhancement New feature or request label May 13, 2021
@stephenlprice stephenlprice linked an issue May 13, 2021 that may be closed by this pull request
refactor SEO component according to social media and Google tutorial #58
Open
stephenlprice
stephenlprice requested changes May 13, 2021
View reviewed changes
Copy link
Member

@stephenlprice stephenlprice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but we need to test it on deployment. It seems to be missing the favicon we had previously.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephenlprice stephenlprice stephenlprice requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@trevorsmithbanjo trevorsmithbanjo

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor SEO component according to social media and Google tutorial
2 participants
@trevorsmithbanjo @stephenlprice