Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct SVT-AV1 defaults to avoid crash #2432

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gianni-rosato
Copy link

Occaisonally, I have observed SVT-AV1 builds on Linux crash due to these two options not being configured properly for CRF encoding. This should fix that issue.

Occaisonally, I have observed SVT-AV1 builds on Linux crash due to these two options not being configured properly for CRF encoding. This should fix that issue.
@maryla-uc
Copy link
Collaborator

Hi,
Thank you for the pull request. Do you have an example file/command line to reproduce the crash? Are you sure this is the right fix? The values you are setting seem to be the default values according to the API and the initialization function (same goes for target_socket) so this change should be a noop.

@gianni-rosato
Copy link
Author

I'll try to reproduce this without this PR. I had a build a couple of weeks ago that was causing issues, and I was confused as well due to the API documentation. Let me get back to you.

@vrabaud
Copy link
Collaborator

vrabaud commented Nov 4, 2024

Thx, this is related to #2412 (comment) right ? to get psy in.

@gianni-rosato
Copy link
Author

This is related to my fork of libavif designed to avoid issues when using SVT-AV1-PSY. This PR might be stale though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants