Warning hunt #383
Open
Warning hunt #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear all,
I noticed many warning related to shadow variable (re-declaration of variable with the same name in 1 scope).
This can really cause trouble during the run so I fixed all of them.
One more reason to do that is that on my robot these warnings are necessarily treated as errors. It's a safety measure used to prevent bugs from happening.
One detail on this PR I reverted the include name from filters (the ros package) from ".hpp" to ".h". As the headers are still maintained in the ".h" form in ROS1 noetic.
This allows me to use your code in melodic while not perturbing the usage in noetic.