Use default C++ and boost::placeholders::_N instead of deprecated _N #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you, should be fine. Processing it with the team. |
| @@ -192,9 +192,11 @@ class FrameManager : public QObject | |||
| template <class M> | |||
| void registerFilterForTransformStatusCheck(tf2_ros::MessageFilter<M>* filter, Display* display) | |||
| { | |||
| filter->registerCallback(boost::bind(&FrameManager::messageCallback<M>, this, _1, display)); | |||
| filter->registerCallback(boost::bind(&FrameManager::messageCallback<M>, this, | |||
There was a problem hiding this comment.
With c++14 it is recommended to use lambdas, not?
There was a problem hiding this comment.
This seems like a smaller change for right now, would prefer to get this in and look into other options later, and I think still is backwards compatible back to c++11 if that is a concern for any other users (but possibly lambdas are too? Would have to look into it).
| @@ -1,7 +1,6 @@ | |||
| cmake_minimum_required(VERSION 3.5.1) | |||
| project(grid_map_cv) | |||
|
|
|||
| set(CMAKE_CXX_FLAGS "-std=c++11 ${CMAKE_CXX_FLAGS}") | |||
| add_compile_options(-Wall -Wextra -Wpedantic) | |||
There was a problem hiding this comment.
set(CMAKE_CXX_STANDARD 17)
?
There was a problem hiding this comment.
The idea here is that I assume every system this is building on now is >= 11 so on Ubuntu 20.04 the default will be 14, and on 22.04 it will be 17, there's no reason to hold it back at 11.
…placeholders::_1 instead of _1, and use new ogre_vector.h to handle deprecation of OgreVector3.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default C++ will be 14 in noetic Ubuntu 20.04, 17 or later on newer systems- 17 is necessary to avoid issues with log4cxx 0.12.
OgreVector3.h is deprecated in newer Ogre versions, a helper file is present in the latest rviz ros-visualization/rviz#1741 (so none of this can be released until rviz with that new header file is released)- I can separate this out into a different commit/PR if desired.
My text editor added newlines to last lines of the files I edit, I can remove those if desired.