-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(optionally) add T/e correction term to Strang Jacobians #1595
base: development
Are you sure you want to change the base?
Conversation
this is the dT/dX |_e term that appears in all species
closes #729 |
some Strang data using
then run the old way:
and it take 8084 steps. Running with the new correction, 6788 steps |
curiously, with |
for He-C-Fe-group, using the correction terms speeds things up by 4x
104499 without the corrections |
Here's some
|
here's a Castro run with these changes: |
this is the dT/dX |_e term that appears in all species
it is now controlled by integrator.correct_jacobian_for_const_e