Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix openmp race conditions in diag #455

Merged
merged 4 commits into from
May 17, 2024
Merged

fix openmp race conditions in diag #455

merged 4 commits into from
May 17, 2024

Conversation

zingale
Copy link
Member

@zingale zingale commented May 15, 2024

there are a few regions where it appears we need a critical block

@zingale
Copy link
Member Author

zingale commented May 15, 2024

addresses #454

@zingale zingale mentioned this pull request May 15, 2024
Closed
@zingale
Copy link
Member Author

zingale commented May 15, 2024

tests pass:
http://groot.astro.sunysb.edu/MAESTROeX/test-suite/gfortran/2024-05-15-001/index.html

@zingale zingale merged commit 1655a05 into AMReX-Astro:development May 17, 2024
11 checks passed
@zingale zingale deleted the fix_omp_diag branch May 17, 2024 19:50
@zingale zingale mentioned this pull request Aug 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@biboyd biboyd biboyd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zingale @biboyd