more clang-tidy fixes

Source/BaseState.H

@@ -154,6 +154,19 @@ class BaseState {
     /// copy constructor. This makes a deep copy of the src.
     BaseState(const BaseState<T>& src);
 
+    // destructor
+    ~BaseState() = default;
+
+    // no copy assignment
+    BaseState& operator= (const BaseState<T>& src) = delete;
+
+    // default move constructor -- we might want to explicitly
+    // implement this, since the compiler might default to copy
+    BaseState(BaseState<T>&& src) = default;
+
+    // no move assignment
+    BaseState& operator= (BaseState<T>&& src) = delete;
+
     /// return a BaseStateArray object to allow for accessing
     /// the underlying data
      [[nodiscard]] AMREX_FORCE_INLINE
@@ -221,7 +234,7 @@ class BaseState {
     void toVector(amrex::Gpu::ManagedVector<T>& vec) const;
 
     /// swap the data with src
-    void swap(BaseState<T>& src);
+    void swap(BaseState<T>& src) noexcept;
 
     T* dataPtr() noexcept { return base_data.dataPtr(); };
 
@@ -478,7 +491,7 @@ void BaseState<T>::toVector(amrex::Gpu::ManagedVector<T>& vec) const {
 }
 
 template <class T>
-void BaseState<T>::swap(BaseState<T>& src) {
+void BaseState<T>::swap(BaseState<T>& src) noexcept {
     AMREX_ASSERT(nlev == src.nlev);
     AMREX_ASSERT(nvar == src.nvar);
     AMREX_ASSERT(len == src.len);

Source/BaseStateGeometry.H

@@ -7,7 +7,7 @@
 
 class BaseStateGeometry {
    public:
-    BaseStateGeometry() noexcept {};
+    BaseStateGeometry() noexcept = default;
 
     void Init(const int max_radial_level_in, const int nr_fine_in,
               const amrex::Real dr_fine_in, const int nr_irreg_in,

Source/Maestro.H

@@ -78,8 +78,21 @@ class Maestro : public amrex::AmrCore {
 
     /// constructor
     Maestro();
+
     /// destructor
-    ~Maestro();
+    ~Maestro() override;
+
+    // copy constructor
+    Maestro(Maestro& other) = delete;
+
+    // move constructor
+    Maestro(Maestro&& other) = delete;
+
+    // copy assignment
+    Maestro& operator= (const Maestro& other) = delete;
+
+    // move assignment
+    Maestro& operator= (Maestro&& other) = delete;
 
     // in `MaestroSetup.cpp`
     /// Setup the simulation.
@@ -771,7 +784,7 @@ class Maestro : public amrex::AmrCore {
     /// finer levels.  This function creates a new fine
     /// level that did not exist before by interpolating from the coarser level
     /// overrides the pure virtual function in `AmrCore`
-    virtual void MakeNewLevelFromScratch(
+    void MakeNewLevelFromScratch(
         int lev, amrex::Real time, const amrex::BoxArray& ba,
         const amrex::DistributionMapping& dm) override;
 

Source/PhysBCFunctMaestro.H

@@ -13,7 +13,7 @@ typedef void (*BndryFuncDefaultMaestro)(
 /// This version calls function working on array
 class BndryFuncArrayMaestro : public amrex::BndryFuncArray {
    public:
-    BndryFuncArrayMaestro() noexcept {}
+    BndryFuncArrayMaestro() = default;
     BndryFuncArrayMaestro(BndryFuncDefaultMaestro inFunc) noexcept
         : m_func(inFunc) {}
 

Util/model_parser/ModelParser.H

@@ -20,7 +20,7 @@ typedef amrex::Vector<int> IntVector;
 
 class ModelParser {
    public:
-    ModelParser() { model_initialized = false; };
+    ModelParser() = default;
 
     void ReadFile(const std::string& model_file);
 
@@ -33,7 +33,7 @@ class ModelParser {
 
     int npts_model;
 
-    bool model_initialized;
+    bool model_initialized{false};
 
     // integer keys for indexing the model_state array
     static constexpr int idens_model = 0;