New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix indexing in geometric source term in ppm tracing for spherical coord #2995

Merged

zingale merged 2 commits into AMReX-Astro:development from zhichen3:prim_geom_source_index

Nov 19, 2024

Collaborator

zhichen3 commented Nov 18, 2024 •

edited

Loading

PR summary

Supposed to load stencil in j instead of i when the normal direction is theta for spherical coord.

PR motivation

PR checklist

test suite needs to be run on this PR
this PR will change answers in the test suite to more than roundoff level
all newly-added functions have docstrings as per the coding conventions
the CHANGES file has been updated, if appropriate
if appropriate, this change is described in the docs

zhichen3 added 2 commits

November 18, 2024 17:37


          fix index error in constructing stencil for geometric source term in …

6c38e5f

…spherical coord


          fix typo

9ffa255

Member

zingale commented Nov 19, 2024

tests: http://groot.astro.sunysb.edu/Castro/test-suite/gfortran/2024-11-18-002/index.html

zingale approved these changes

View reviewed changes

zingale merged commit 885e9c0 into AMReX-Astro:development

25 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet