update source_flag to work with spherical and allow geometric source terms for 1d spherical #2993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
good catch! |
zingale
reviewed
Nov 13, 2024
| if (geom.Coord() == 1) { | ||
| return true; | ||
| } else { | ||
| if (geom.Coord() == 0) { |
There was a problem hiding this comment.
there aren't any geometry sources for 1-d spherical or cylindrical either, right?
There was a problem hiding this comment.
I think it depends on what does 1d spherical mean exactly. Are we assuming purely 1d with velocities in theta and phi direction being 0 or are we assuming 3d but with theta and phi symmetry?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
update source_flag to work with spherical and allow geometric source terms for 1d spherical
PR motivation
PR checklist
CHANGESfile has been updated, if appropriate