Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] turn on simplified-SDC for massive_star #2655

Closed
wants to merge 6 commits into from
Closed

[WIP] turn on simplified-SDC for massive_star #2655

wants to merge 6 commits into from

Conversation

zingale
Copy link
Member

@zingale zingale commented Nov 21, 2023

also use the chabrier1998 screening to be consistent with the table

PR summary

PR motivation

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

@zingale
Copy link
Member Author

zingale commented Dec 18, 2023

redoing this with the latest options

@zingale zingale closed this Dec 18, 2023
@zingale zingale deleted the massive_star_screening branch December 18, 2023 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@zingale