Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add an action to enforce consistency in GNUmakefiles #2642

Merged
merged 6 commits into from
Oct 20, 2023
Merged

add an action to enforce consistency in GNUmakefiles #2642

merged 6 commits into from
Oct 20, 2023

Conversation

zingale
Copy link
Member

@zingale zingale commented Oct 19, 2023

PR summary

PR motivation

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

@zingale
Copy link
Member Author

zingale commented Oct 19, 2023

I think this works now. Do we also want to enforce a default for USE_OMP? I think we should default it to FALSE

@zingale zingale merged commit 274a15e into AMReX-Astro:development Oct 20, 2023
19 checks passed
@zingale zingale deleted the check_makefiles branch October 20, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxpkatz maxpkatz maxpkatz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zingale @maxpkatz