Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert RadInterpBndryData routines to C++ #2638

Merged
merged 12 commits into from
Nov 2, 2023

Conversation

maxpkatz
Copy link
Member

PR summary

This PR combines the six boundary interpolation routines into one loop. The loop structure is designed in such a way that all six 2D faces are automatically recoverable, even though we write it as if it is 3D.

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

@maxpkatz maxpkatz marked this pull request as ready for review October 30, 2023 02:27
@zingale
Copy link
Member

zingale commented Oct 30, 2023

@maxpkatz
Copy link
Member Author

maxpkatz commented Nov 1, 2023

some test suite failures: http://groot.astro.sunysb.edu/Castro/test-suite/gfortran/2023-10-30-002/index.html

I believe I have resolved this

@zingale
Copy link
Member

zingale commented Nov 1, 2023

@zingale
Copy link
Member

zingale commented Nov 2, 2023

@zingale zingale merged commit da3e4b7 into AMReX-Astro:development Nov 2, 2023
19 checks passed
@maxpkatz maxpkatz deleted the cxx-radinterpbndrydata branch November 2, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants