Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean up the runtime parameter parser #2576

Merged
merged 1 commit into from
Sep 23, 2023
Merged

clean up the runtime parameter parser #2576

merged 1 commit into from
Sep 23, 2023

Conversation

zingale
Copy link
Member

@zingale zingale commented Sep 23, 2023

remove the "in fortran" option as well as the field from the _cpp_parameters file and also split the parser into 2 function to make it easier to build off of.

PR summary

PR motivation

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

@zingale
clean up the runtime parameter parser
f2ad04a 
remove the "in fortran" option as well as the field from the
_cpp_parameters file and also split the parser into 2 function
to make it easier to build off of.
@zingale zingale mentioned this pull request Sep 23, 2023
Merged
5 tasks
@zingale zingale merged commit 41558be into AMReX-Astro:development Sep 23, 2023
17 checks passed
@zingale zingale deleted the clean_up_parser branch September 23, 2023 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxpkatz maxpkatz maxpkatz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zingale @maxpkatz