Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove sdc_solve_for_rhoe #2572

Merged
merged 27 commits into from
Sep 23, 2023
Merged

remove sdc_solve_for_rhoe #2572

merged 27 commits into from
Sep 23, 2023

Conversation

zingale
Copy link
Member

@zingale zingale commented Sep 22, 2023

PR summary

This is no longer used since we are leveraging the same code paths as
simplified-SDC

PR motivation

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

@zingale
move SDC-specific routiens into Source/sdc
32f09b5
@zingale
Merge branch 'development' of github.com:amrex-astro/Castro into deve…
8795437 
…lopment
@zingale
move the Newton solver into its own header
30862ec
@zingale
start removing density from the reacting system
fcf55d9
@zingale
the Newton stuff compiles now
1ebc26d
@zingale
this builds and runs
27f8b32 
note: VODE is commented out
@zingale
fix codespell
426b621
@zingale
Merge branch 'development' into sdc_cleaning_III
c3a4c40
@zingale
some vode work
2298fce
@zingale
Merge branch 'development' into sdc_cleaning
243e09b
@zingale
Merge branch 'sdc_cleaning' into sdc_cleaning_II
af5f653
@zingale
Merge branch 'sdc_cleaning_II' into sdc_cleaning_III
a16e3bb
@zingale
some more cleaning
074590d
@zingale
Merge branch 'development' into sdc_cleaning_II
0ca5370
@zingale
Merge branch 'sdc_cleaning_II' into sdc_cleaning_III
7097f1c
@zingale
I think this is how it should be now for VODE
e19d77b
@zingale
Merge branch 'development' into sdc_cleaning_III
06919ca
@zingale
fix
893c1cb
@zingale
fix
f9be052
@zingale
Merge branch 'development' into sdc_cleaning_III
bbaf405
@zingale
Merge branch 'development' into sdc_cleaning_III
5a7b886
@zingale
update benchmark
8cfb5be
@zingale
fix loop
3b7d2f0
@zingale
remove sdc_solve_for_rhoe
e4d61ac
@zingale zingale changed the base branch from main to development September 22, 2023 12:50
@zingale
Copy link
Member Author

zingale commented Sep 22, 2023

depends on #2560

@zingale zingale added the sdc label Sep 22, 2023
@zingale zingale changed the title [WIP] remove sdc_solve_for_rhoe remove sdc_solve_for_rhoe Sep 22, 2023
@zingale zingale merged commit 9d00bf8 into AMReX-Astro:development Sep 23, 2023
17 checks passed
@zingale zingale deleted the sdc_cleaning_V branch September 23, 2023 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxpkatz maxpkatz maxpkatz approved these changes

Assignees
No one assigned
Labels
sdc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zingale @maxpkatz