Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename model_parser_cxx to strip unnecessary C++ identifier #2546

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

maxpkatz
Copy link
Member

@maxpkatz maxpkatz commented Sep 8, 2023

PR summary

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

@zingale
Copy link
Member

zingale commented Sep 8, 2023

@zingale zingale merged commit ecf66c3 into AMReX-Astro:development Sep 8, 2023
17 checks passed
@maxpkatz maxpkatz deleted the cxx_model_parser branch September 8, 2023 15:29
yut23 added a commit to yut23/Castro that referenced this pull request Sep 29, 2023
These were added in PRs that were started before AMReX-Astro#2546, but were merged
after it.
zingale pushed a commit that referenced this pull request Sep 29, 2023
These were added in PRs that were started before #2546, but were merged
after it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants