Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revive temperature-based ppm tracing #2192

Closed
wants to merge 27 commits into from
Closed

revive temperature-based ppm tracing #2192

wants to merge 27 commits into from

Conversation

zingale
Copy link
Member

@zingale zingale commented May 11, 2022

PR summary

PR motivation

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

@zingale
Copy link
Member Author

zingale commented May 11, 2022

this seems to work, but I need to

  1. figure out the T source term
  2. figure out the T geometry term

@zingale
Copy link
Member Author

zingale commented May 17, 2022

this is part of #781

@zingale zingale marked this pull request as ready for review April 15, 2023 22:16
@zingale zingale marked this pull request as draft April 15, 2023 22:16
@zingale zingale added the hydro label Oct 2, 2023
@zingale
Copy link
Member Author

zingale commented Nov 17, 2024

I think that this just turns out to be too diffusive

@zingale zingale closed this Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
hydro
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@zingale