Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement reference state in MHD PLM #1021

Draft
wants to merge 95 commits into
base: development
Choose a base branch
from
Draft

implement reference state in MHD PLM #1021

wants to merge 95 commits into from
+105 −36

Conversation

zingale
Copy link
Member

@zingale zingale commented Jun 7, 2020

PR summary

This implements the reference state in the characteristic project a la Colella 1990 or Stone et al. 2008.

PR motivation

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

zingale added 30 commits May 20, 2020 15:02
@zingale
port primtocons and prim_half to C++
a73c96f
@zingale
Merge branch 'development' of github.com:amrex-astro/Castro into deve…
a958e57 
…lopment
@zingale
Merge branch 'development' of github.com:zingale/Castro into development
1067d9e
@zingale
Merge branch 'development' of github.com:amrex-astro/Castro into deve…
4ac4eea 
…lopment
@zingale
Merge branch 'development' of github.com:amrex-astro/Castro into deve…
f90440b 
…lopment
@zingale
Merge branch 'development' of github.com:AMReX-Astro/Castro into deve…
f19a376 
…lopment
@zingale
we don't need NHYP in Fortran, so just define NUM_GROW in C++
a63553f
@zingale
Merge branch 'development' of github.com:amrex-astro/Castro into deve…
5ad38f8 
…lopment
@zingale
we need 6 ghost cells for MHD + flattening
ae57a16
@zingale
add comment
1b40ecb
@zingale
Merge branch 'development' into mhd_flattening
8718d24
@zingale
add the computation of qptot for MHD
ff14776
@zingale
don't let any coarse grid have < NUM_GROW cells
57671d9
@zingale
remove debugging prints
e5ec8f4
@zingale
Merge branch 'development' of github.com:amrex-astro/Castro into deve…
5fb18e2 
…lopment
@zingale
Merge branch 'development' into num_grow
3c4cb19
@zingale
Merge branch 'num_grow' into mhd_flattening
309e408
@zingale
remove old headers
6e9b1cf
@zingale
start working on the PLM conversion
41a769b
@zingale
more work on the eigensystem
145271f
@zingale
Merge branch 'development' of github.com:AMReX-Astro/Castro into deve…
03dd305 
…lopment
@zingale
port the eigenstuff to C++
8011c33
@zingale
Merge branch 'development' of github.com:amrex-astro/Castro into deve…
f6fec91 
…lopment
@zingale
Merge branch 'development' into mhd_flattening
3839f40
@zingale
Merge branch 'mhd_flattening' into mhd_plm
3fc63f9
@zingale
remove more headers
ea27c20
@zingale
finish first pass
d280f6b
@zingale
this compiles now
1c2718a
@zingale
add missing file
5c0edb5
@zingale
fix index bug
a247579
zingale added 29 commits May 28, 2020 09:03
@zingale
Merge branch 'development' of github.com:zingale/Castro into development
631fa96
@zingale
Merge branch 'development' of github.com:zingale/Castro into development
255b654
@zingale
Merge branch 'development' of github.com:zingale/Castro into development
8179a37
@zingale
Merge branch 'development' of github.com:AMReX-Astro/Castro into deve…
9bcd86b 
…lopment
@zingale
Merge branch 'development' of github.com:amrex-astro/Castro into deve…
dfd4ba1 
…lopment
@zingale
Merge branch 'development' of github.com:AMReX-Astro/Castro into deve…
01a2fc1 
…lopment
@zingale
Merge branch 'development' of github.com:amrex-astro/Castro into deve…
4c13af8 
…lopment
@zingale
Merge branch 'development' of github.com:zingale/Castro into development
718f5f6
@zingale
Merge branch 'development' of github.com:AMReX-Astro/Castro into deve…
5c356c1 
…lopment
@zingale
Merge branch 'development' of github.com:amrex-astro/Castro into deve…
f728392 
…lopment
@zingale
Merge branch 'development' of github.com:zingale/Castro into development
0ae2d78
@zingale
Merge branch 'development' of github.com:zingale/Castro into development
284def0
@zingale
Merge branch 'development' into mhd_plm
802dfd6
@zingale
this implements a reference state in MHD PLM
d8a3301 
basically does what is in Colella 1990 / Stone et al. 2008
@zingale
fix indexing
0ed2843
@zingale
Merge branch 'development' of github.com:amrex-astro/Castro into deve…
e1d5da9 
…lopment
@zingale
Merge branch 'development' of github.com:amrex-astro/Castro into deve…
b72cb25 
…lopment
@zingale
Merge branch 'development' of github.com:zingale/Castro into development
8b19e60
@zingale
Merge branch 'development' of github.com:amrex-astro/Castro into deve…
60280ba 
…lopment
@zingale
Merge branch 'development' of github.com:zingale/Castro into development
966391e
@zingale
Merge branch 'development' of github.com:AMReX-Astro/Castro into deve…
1c0df95 
…lopment
@zingale
Merge branch 'development' of github.com:AMReX-Astro/Castro into deve…
0f5a6ce 
…lopment
@zingale
Merge branch 'development' of github.com:zingale/Castro into development
3d9e0ef
@zingale
Merge branch 'development' of github.com:amrex-astro/Castro into deve…
50f44b8 
…lopment
@zingale
Merge branch 'development' into mhd_plm
ce449c2
@zingale
Merge branch 'development' of github.com:zingale/Castro into development
79a7a85
@zingale
Merge branch 'development' of github.com:amrex-astro/Castro into deve…
676ff93 
…lopment
@zingale
Merge branch 'development' into mhd_plm
28ac10d
@zingale
Merge branch 'development' into mhd_plm
1297413
@zingale zingale added the mhd label Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
mhd
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@zingale