Skip to content

Commit

Permalink
hvf: arm: Do not advance PC when raising an exception
Browse files Browse the repository at this point in the history
hvf did not advance PC when raising an exception for most unhandled
system registers, but it mistakenly advanced PC when raising an
exception for GICv3 registers.

Cc: [email protected]
Fixes: a226098 ("hvf: arm: Add support for GICv3")
Signed-off-by: Akihiko Odaki <[email protected]>
Message-id: [email protected]
Reviewed-by: Peter Maydell <[email protected]>
Signed-off-by: Peter Maydell <[email protected]>
  • Loading branch information
akihikodaki authored and pm215 committed Jul 18, 2024
1 parent 71328d8 commit 30a1690
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions target/arm/hvf/hvf.c
Original file line number Diff line number Diff line change
Expand Up @@ -1278,6 +1278,7 @@ static int hvf_sysreg_read(CPUState *cpu, uint32_t reg, uint32_t rt)
/* Call the TCG sysreg handler. This is only safe for GICv3 regs. */
if (!hvf_sysreg_read_cp(cpu, reg, &val)) {
hvf_raise_exception(cpu, EXCP_UDEF, syn_uncategorized());
return 1;
}
break;
case SYSREG_DBGBVR0_EL1:
Expand Down

0 comments on commit 30a1690

Please sign in to comment.