Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Congo dts changes #47

Open
wants to merge 2 commits into
base: integ_sp7
Choose a base branch
from
Open

Congo dts changes #47

wants to merge 2 commits into from

Conversation

abinayaddhandapani
Copy link
Collaborator

  1. Remove the pinctrl-related properties for i2c0 and i2c1
     to free up the original physical pins for other functions.
    
  2.  Lower the APML bus frequency from 12.5 Mhz to
    10 Mhz to enable APML in Congo.
    

Abinaya Dhandapani added 2 commits December 6, 2024 23:51
Lower the APML bus frequency from 12.5 Mhz to
10 Mhz to enable APML in Congo.
(This change needs to be reverted back when
the APML bus starts working at 12.5Mhz)

Signed-off-by: Abinaya Dhandapani <[email protected]>
Remove the pinctrl-related properties for i2c0 and i2c1
to free up the original physical pins for other functions.

Signed-off-by: Abinaya Dhandapani <[email protected]>
Copy link
Collaborator

@mahkurap mahkurap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you planning to change Morocco, Kenya and Nigeria device trees also?

Copy link
Collaborator

@mahkurap mahkurap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where are these released pins be used?

@@ -174,6 +174,8 @@
};

&i2c0 {
/delete-property/ pinctrl-names;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where are the released pins be used?

Copy link
Collaborator

@mahkurap mahkurap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you planning other commits for Morocco, Kenya and Nigeria also?

@abinayaddhandapani
Copy link
Collaborator Author

@mahkurap Other platforms already has the delete-property added.
If this is not added, we cannot access the flash for remote bios update and it will be holded by i2c0.

@ojayanth
Copy link
Collaborator

General Comments: Please provide meaning full name for PR (seems to be generic Congo dts changes), for future track , congo updates seems to be common .

  • Add tested fields in the commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants